Skip to content

Commit c60c126

Browse files
committed
Address feedback to remove superfluous test
1 parent 4c9c81b commit c60c126

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

tests/command.bats

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -529,34 +529,6 @@ DOCKER_STUB_DEFAULT_OPTIONS='--log-level error run --rm --volume \* --volume \*
529529
rm "${annotation_input}"
530530
}
531531

532-
@test "runs in docker by default" {
533-
export BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS="junits/*.xml"
534-
export BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAIL_BUILD_ON_ERROR=false
535-
536-
stub mktemp \
537-
"-d \* : mkdir -p '$artifacts_tmp'; echo '$artifacts_tmp'" \
538-
"-d \* : mkdir -p '$annotation_tmp'; echo '$annotation_tmp'"
539-
540-
stub buildkite-agent \
541-
"artifact download \* \* : echo Downloaded artifact \$3 to \$4" \
542-
"annotate --context \* --style \* : cat >'${annotation_input}'; echo Annotation added with context \$3 and style \$5, content saved"
543-
544-
stub docker \
545-
"${DOCKER_STUB_DEFAULT_OPTIONS} ruby /src/bin/annotate /junits : echo '<details>Failure</details>' && exit 64"
546-
547-
run "$PWD/hooks/command"
548-
549-
assert_success
550-
551-
assert_output --partial "Annotation added with context junit and style error"
552-
assert_equal "$(cat "${annotation_input}")" '<details>Failure</details>'
553-
554-
unstub mktemp
555-
unstub buildkite-agent
556-
unstub docker
557-
rm "${annotation_input}"
558-
}
559-
560532
@test "does not run in docker when run-in-docker is false" {
561533
export BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS="junits/*.xml"
562534
export BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAIL_BUILD_ON_ERROR=false

0 commit comments

Comments
 (0)