Merge pull request #139 from cursande/master

Allow junits_dir to match hidden files and dirs

Author: pzeballos

ruby/bin/annotate

@@ -25,7 +25,7 @@ end
 class Timing < Struct.new(:name, :unit_name, :time)
 end
 
-junit_report_files = Dir.glob(File.join(junits_dir, "**", "*"))
+junit_report_files = Dir.glob(File.join(junits_dir, "**", "*"), File::FNM_DOTMATCH)
 testcases = 0
 failures = []
 timings = []

ruby/tests/.tests-in-hidden-dir/junit-1.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite name="rspec" tests="2" skipped="0" failures="0" errors="0" time="49.290713" timestamp="2018-04-18T23:29:42+00:00" hostname="626d214475e4">
+  <testcase classname="spec.models.account_spec" name="Account#maximum_jobs_added_by_pipeline_changer returns 700 if the account is XYZ" file="./spec/models/account_spec.rb" time="0.020013"/>
+  <testcase classname="spec.models.account_spec" name="Account#maximum_jobs_added_by_pipeline_changer returns 900 if the account is F00" file="./spec/models/account_spec.rb" time="0.020013"/>
+</testsuite>

ruby/tests/annotate_test.rb

@@ -521,4 +521,17 @@
 
     assert_equal 0, status.exitstatus
   end
+
+  it "handles junit dir paths with hidden directories" do
+    output, status = Open3.capture2e("#{__dir__}/../bin/annotate", "#{__dir__}/.tests-in-hidden-dir/")
+
+    assert_equal <<~OUTPUT, output
+      Parsing junit-1.xml
+      --- ❓ Checking failures
+      2 testcases found
+      There were no failures/errors 🙌
+    OUTPUT
+
+    assert_equal 0, status.exitstatus
+  end
 end