using abort vs raise; adding enum to plugin.yml

Author: Nicole Lopez

plugin.yml

@@ -11,6 +11,9 @@ configuration:
       type: string
     failure-format:
       type: string
+      enum:
+        - classname
+        - file
   required:
     - artifacts
   additionalProperties: false

ruby/bin/annotate

@@ -14,8 +14,10 @@ job_pattern = '-(.*).xml' if !job_pattern || job_pattern.empty?
 
 failure_format = ENV['BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAILURE_FORMAT']
 failure_format = 'classname' if !failure_format || failure_format.empty?
+
+# TODO -- remove this validation once https://github.com/buildkite/agent/pull/748 is merged
 if !%w(classname file).include?(failure_format)
-  raise ArgumentError.new("Invalid failure-format #{failure_format} provided -- leave this setting blank or specify `file` or `classname`")
+  abort("Invalid failure-format #{failure_format} provided -- leave this setting blank or specify `file` or `classname`")
 end
 
 class Failure < Struct.new(:name, :failed_test, :body, :job, :type)