I now ensure unsupported http client options log a fatal error

Author: wolfeidau

clicommand/agent_start.go

@@ -1104,8 +1104,12 @@ var AgentStartCommand = cli.Command{
 
 		l.Info("Using http client profile: %s", cfg.HTTPClientProfile)
 
-		if !slices.Contains(agenthttp.ValidHTTPClientProfiles, cfg.HTTPClientProfile) {
-			l.Fatal("HTTP client profile %s is not in list of valid profiles: %v", cfg.HTTPClientProfile, agenthttp.ValidHTTPClientProfiles)
+		if !slices.Contains(agenthttp.ValidClientProfiles, cfg.HTTPClientProfile) {
+			l.Fatal("HTTP client profile %s is not in list of valid profiles: %v", cfg.HTTPClientProfile, agenthttp.ValidClientProfiles)
+		}
+
+		if cfg.HTTPClientProfile == agenthttp.ClientProfileStdlib && cfg.NoHTTP2 {
+			l.Fatal("NoHTTP2 is not supported with the standard library (%s) HTTP client profile, use GODEBUG see https://pkg.go.dev/net/http#hdr-HTTP_2", agenthttp.ClientProfileStdlib)
 		}
 
 		if len(cfg.AllowedRepositories) > 0 {

internal/agenthttp/client.go

@@ -12,8 +12,11 @@ import (
 )
 
 var (
+	ClientProfileDefault = "default"
+	ClientProfileStdlib  = "stdlib"
+
 	// ValidHTTPClientProfiles lists accepted values for Config.HTTPClientProfile.
-	ValidHTTPClientProfiles = []string{"stdlib", "default"}
+	ValidClientProfiles = []string{ClientProfileDefault, ClientProfileStdlib}
 )
 
 // NewClient creates a HTTP client. Note that the default timeout is 60 seconds;
@@ -34,7 +37,7 @@ func NewClient(opts ...ClientOption) *http.Client {
 	// http client profile is used to switch between different http client implementations
 	// - stdlib: uses the standard library http client
 	switch conf.HTTPClientProfile {
-	case "stdlib":
+	case ClientProfileStdlib:
 		// Base any modifications on the default transport.
 		transport := http.DefaultTransport.(*http.Transport).Clone()