Remove sleep, increase app restart delay to resolve race condition

Author: Chloe Hutchinson

packer/windows/conf/bin/bk-install-elastic-stack.ps1

@@ -170,7 +170,7 @@ nssm set buildkite-agent AppEnvironmentExtra :HOME=C:\buildkite-agent
 If ($lastexitcode -ne 0) { Exit $lastexitcode }
 nssm set buildkite-agent AppExit Default Restart
 If ($lastexitcode -ne 0) { Exit $lastexitcode }
-nssm set buildkite-agent AppRestartDelay 5000
+nssm set buildkite-agent AppRestartDelay 10000
 If ($lastexitcode -ne 0) { Exit $lastexitcode }
 nssm set buildkite-agent AppEvents Exit/Post "powershell C:\buildkite-agent\bin\terminate-instance.ps1"
 If ($lastexitcode -ne 0) { Exit $lastexitcode }

packer/windows/conf/buildkite-agent/scripts/terminate-instance.ps1

@@ -1,6 +1,3 @@
-Write-Output "terminate-instance: waiting for 10 seconds to allow agent logs to drain to Cloudwatch..."
-Start-Sleep -Seconds 10
-
 $InstanceId = (Invoke-WebRequest -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
 $Region = (Invoke-WebRequest -UseBasicParsing http://169.254.169.254/latest/meta-data/placement/availability-zone).content -replace ".$"