Skip to content

Commit d06ac87

Browse files
author
James Healy
committed
allow multiple / characters in BuildkiteAgentTokenParameterStorePath
In #813 we added a regexp validation to this stack parameter that was intended to check the parameter is either an empty string or a path that starts with a / character. The list of characters we permitted comes from [1]. However, we forgot to include / as a permitted character beyond the first. It's valid (and common) for paths to have multiple / to indicate hierarchy and we should support it. Fixes #834 [1] https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-paramstore-su-create.html
1 parent fde968a commit d06ac87

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

templates/aws-stack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ Parameters:
113113
Description: AWS SSM path to the Buildkite agent registration token (this takes precedence over BuildkiteAgentToken). Expects a leading slash ('/').
114114
Type: String
115115
Default: ""
116-
AllowedPattern: "^$|^/[a-zA-Z0-9_.-]+$"
116+
AllowedPattern: "^$|^/[a-zA-Z0-9_.-/]+$"
117117

118118
BuildkiteAgentTokenParameterStoreKMSKey:
119119
Description: AWS KMS key ID used to encrypt the SSM parameter (if encrypted)

0 commit comments

Comments
 (0)