Skip to content

Commit ffe4a61

Browse files
committed
Quote arguments to echos
While echo will print its arguments separated by spaces, if we need more than a single space, quotes are necessary. So for consistency, I will quote all arguments to echo from now on.
1 parent 66a73fd commit ffe4a61

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.buildkite/steps/copy.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ EOF
130130
exit 0
131131
fi
132132

133-
echo --- Tagging AMIs as released
133+
echo "--- Tagging AMIs as released"
134134
if [[ $BUILDKITE_BRANCH == main || $BUILDKITE_TAG == "$BUILDKITE_BRANCH" || ${TAG_IS_RELEASED:-false} == true ]]; then
135135
tag-ami "$linux_amd64_source_image_id" "$source_region" IsReleased true
136136
tag-ami "$linux_arm64_source_image_id" "$source_region" IsReleased true
137137
tag-ami "$windows_amd64_source_image_id" "$source_region" IsReleased true
138138
fi
139139

140-
echo --- Tagging elastic ci stack release version
140+
echo "--- Tagging elastic ci stack release version"
141141
echo "Note: the same AMI may be used in multiple versions of the elastic stack,"
142142
echo "so we can't use the same tag key for each version."
143143
if [[ $BUILDKITE_TAG == "$BUILDKITE_BRANCH" || ${TAG_VERSION:-false} == true ]]; then
@@ -146,7 +146,7 @@ if [[ $BUILDKITE_TAG == "$BUILDKITE_BRANCH" || ${TAG_VERSION:-false} == true ]];
146146
tag-ami "$windows_amd64_source_image_id" "$source_region" "Version:${BUILDKITE_TAG}" true
147147
fi
148148

149-
echo --- Checking if there is a previously copy in the cache bucket
149+
echo "--- Checking if there is a previously copy in the cache bucket"
150150
s3_mappings_cache=$(printf "s3://%s/mappings-%s-%s-%s-%s.yml" \
151151
"${BUILDKITE_AWS_STACK_BUCKET}" \
152152
"${linux_amd64_source_image_id}" \
@@ -159,7 +159,7 @@ if aws s3 cp "${s3_mappings_cache}" "$mapping_file"; then
159159
exit 0
160160
fi
161161

162-
echo --- Copying images to other regions
162+
echo "--- Copying images to other regions"
163163

164164
# Get the image names to copy to other regions
165165
linux_amd64_source_image_name=$(get_image_name "$linux_amd64_source_image_id" "$source_region")

0 commit comments

Comments
 (0)