Use query syntax to sub in us-east-1 for the Null region constraint of those buckets

Author: keithduncan

git-credential-s3-secrets

@@ -71,7 +71,9 @@ s3_bucket_region() {
     guess_region="us-east-1"
   fi
 
-  local bucket_region="$(aws s3api get-bucket-location --bucket "${bucket}" --region "${guess_region}" --output text)"
+  # Buckets in us-east-1 have a LocationConstraint of null
+  # https://docs.aws.amazon.com/cli/latest/reference/s3api/get-bucket-location.html
+  local bucket_region="$(aws s3api get-bucket-location --bucket "${bucket}" --region "${guess_region}" --output text --query "LocationConstraint || 'us-east-1'")"
 
   echo "${bucket_region}"
 }