Revert "Do not reconcile images and builds being deleted"

This reverts commit 1d6a5b2.

Co-authored-by: Danail Branekov <danailster@gmail.com>

Author: georgethebeatle

pkg/reconciler/build/build.go

@@ -136,10 +136,6 @@ func (c *Reconciler) Reconcile(ctx context.Context, key string) error {
 		return err
 	}
 
-	if build.DeletionTimestamp != nil {
-		return nil
-	}
-
 	build = build.DeepCopy()
 	build.SetDefaults(ctx)
 

pkg/reconciler/build/build_test.go

@@ -258,23 +258,6 @@ func testBuildReconciler(t *testing.T, when spec.G, it spec.S) {
 			})
 		})
 
-		it("does not reconcile a build being deleted", func() {
-			bld.Status.ObservedGeneration = 1
-
-			bld.Generation = 2
-			deletionTimetamp := metav1.NewTime(time.Now())
-			bld.DeletionTimestamp = &deletionTimetamp
-
-			rt.Test(rtesting.TableRow{
-				Key: key,
-				Objects: []runtime.Object{
-					bld,
-				},
-				WantErr:           false,
-				WantStatusUpdates: []clientgotesting.UpdateActionImpl{},
-			})
-		})
-
 		it("does not update status if there is no update", func() {
 			buildPod, err := podGenerator.Generate(ctx, bld)
 			require.NoError(t, err)

pkg/reconciler/image/image.go

@@ -121,10 +121,6 @@ func (c *Reconciler) Reconcile(ctx context.Context, key string) error {
 		return err
 	}
 
-	if image.DeletionTimestamp != nil {
-		return nil
-	}
-
 	image = image.DeepCopy()
 	image.SetDefaults(ctx)
 

pkg/reconciler/image/image_test.go

@@ -252,27 +252,6 @@ imageWithBuilder := &buildapi.Image{
 			})
 		})
 
-		it("does not reconcile images being deleted", func() {
-			const observedGeneration int64 = 1
-			imageWithBuilder.Status.ObservedGeneration = observedGeneration
-
-			imageWithBuilder.Generation = 2
-			deletionTimetamp := metav1.NewTime(time.Now())
-			imageWithBuilder.DeletionTimestamp = &deletionTimetamp
-
-			rt.Test(rtesting.TableRow{
-				Key: key,
-				Objects: []runtime.Object{
-					imageWithBuilder,
-					builder,
-					clusterBuilder,
-					unresolvedSourceResolver(imageWithBuilder),
-				},
-				WantErr:           false,
-				WantStatusUpdates: []clientgotesting.UpdateActionImpl{},
-			})
-		})
-
 		it("does not update status if there is no status update", func() {
 			rt.Test(rtesting.TableRow{
 				Key: key,