Fix macOS startup by adding electron-rebuild step #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the application on macOS, node-pty native bindings need to be rebuilt for the local Electron version. Added 'npx electron-rebuild -f -w node-pty' to the start script to ensure the application starts properly on macOS systems.
Owner
|
Perhaps we could just do a rebuild for all modules instead of just node-pty? WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run the application on my MacBook, I encountered issues with node-pty native bindings. The app needed the electron-rebuild command to properly rebuild native modules for the local Electron version.
This PR adds
npx electron-rebuild -f -w node-ptyto the start script to ensure the application starts properly on macOS systems without manual intervention.Changes
package.jsonstart script to includenpx electron-rebuild -f -w node-ptybefore launching ElectronTesting
Tested on macOS and confirmed the application now starts successfully without manual rebuild steps.