Skip to content

Commit 54f5222

Browse files
Make default Rails version 7.X instead of 7.0.X (#85)
* Make default Rails version 7.X instead of 7.0.X When trying to launch the Rails server with the Rails version set to the latest 7.0.X, it fails with the following error message: ```txt uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError) ``` The [issue](rails/rails#54271) has been solved in Rails version 7.1.X, and so we should stop using the 7.0.X version as the default in development mode for the showcase engine. * Run bin/highlights to make test pass * Drop support for Rails 6.X and Ruby 2.X
1 parent 18e3d2e commit 54f5222

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,11 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
rails-version:
16-
- "7.1"
17-
- "6.1"
16+
- "7.2"
17+
- "8.0"
1818
- "main"
1919
ruby-version:
20-
- "3.2"
21-
- "2.7"
20+
- "3.4"
2221

2322
env:
2423
RAILS_ENV: test

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ gemspec
66

77
gem "sqlite3"
88

9-
rails_version = ENV.fetch("RAILS_VERSION", "7.0")
9+
rails_version = ENV.fetch("RAILS_VERSION", "7")
1010

1111
rails_constraint = if rails_version == "main"
1212
{github: "rails/rails"}

app/assets/builds/showcase.highlights.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@
3939
color: #116329;
4040
background-color: #dafbe1;
4141
}
42+
.sc-highlight .ges {
43+
font-weight: bold;
44+
font-style: italic;
45+
}
4246
.sc-highlight .kc {
4347
color: #0550ae;
4448
}
@@ -153,6 +157,10 @@
153157
color: #aff5b4;
154158
background-color: #033a16;
155159
}
160+
.sc-highlight .ges {
161+
font-weight: bold;
162+
font-style: italic;
163+
}
156164
.sc-highlight .kc {
157165
color: #79c0ff;
158166
}

showcase.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ Gem::Specification.new do |spec|
1717
Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
1818
end
1919

20-
spec.add_dependency "rails", ">= 6.1.0"
20+
spec.add_dependency "rails", ">= 7.2"
2121
spec.add_development_dependency "tailwindcss-rails"
2222
end

0 commit comments

Comments
 (0)