Skip to content

Commit 7c6e926

Browse files
johnsully83jgodi
authored andcommitted
fix(calendar): Fixing some calendar bugs
1 parent fe0fe73 commit 7c6e926

File tree

6 files changed

+20
-19
lines changed

6 files changed

+20
-19
lines changed

demo/pages/elements/calendar/CalendarDemo.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ export class CalendarDemoComponent {
104104
return evt;
105105
}
106106

107-
dayClicked(event) {
108-
let evt: CalendarEvent = this.getNewEvent(event.day.date, colors.blue, CalendarEventResponse.Maybe);
107+
dayClicked(date) {
108+
let evt: CalendarEvent = this.getNewEvent(date, colors.blue, CalendarEventResponse.Maybe);
109109
this.events.push(evt);
110110
this.events = [...this.events];
111111
}

demo/pages/elements/calendar/templates/CalendarDemo.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
*ngSwitchCase="'month'"
1010
[(viewDate)]="viewDate"
1111
[events]="events"
12-
(dayClicked)="dayClicked($event)">
12+
(dayClicked)="dayClicked($event.day.date)">
1313
</novo-calendar-month>
1414

1515
<novo-calendar-week
1616
*ngSwitchCase="'week'"
1717
[(viewDate)]="viewDate"
1818
[events]="events"
19-
(eventClicked)="dayClicked($event)"
19+
(dayClicked)="dayClicked($event.date)"
2020
[dayStartHour]="0"
2121
[dayEndHour]="24">
2222
</novo-calendar-week>
@@ -25,7 +25,6 @@
2525
*ngSwitchCase="'day'"
2626
[(viewDate)]="viewDate"
2727
[events]="events"
28-
(eventClicked)="dayClicked($event)"
2928
[dayStartHour]="0"
3029
[dayEndHour]="24">
3130
</novo-calendar-day>

src/elements/calendar/day/CalendarDayEvent.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import { DayViewEvent } from '../../../utils/calendar-utils/CalendarUtils';
1212
[class.cal-ends-within-day]="!dayEvent.endsAfterDay"
1313
[ngClass]="dayEvent.event.cssClass"
1414
[tooltip]="dayEvent.event.title"
15-
[tooltipPosition]="tooltipPosition">
15+
[tooltipPosition]="tooltipPosition"
16+
(click)="eventClicked.emit({event: dayEvent.event})">
1617
<div class="cal-event-ribbon" [style.backgroundColor]="dayEvent.event.color.primary"></div>
1718
<div class="cal-event-group">
1819
<div class="cal-event-title">{{dayEvent.event.title}}</div>

src/elements/calendar/day/CalendarDayView.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const MINUTES_IN_HOUR: number = 60;
7373
[dayEvent]="dayEvent"
7474
[tooltipPosition]="tooltipPosition"
7575
[customTemplate]="eventTemplate"
76-
(eventClicked)="eventClicked.emit({event: dayEvent.event})">
76+
(eventClicked)="eventClicked.emit($event)">
7777
</novo-calendar-day-event>
7878
</div>
7979
</div>
@@ -290,7 +290,7 @@ export class NovoCalendarDayViewElement implements OnChanges, OnInit, OnDestroy
290290
this.eventTimesChanged.emit({event: dropEvent.dropData.event, newStart: segment.date});
291291
}
292292
}
293-
293+
294294
resizeStarted(event: DayViewEvent, resizeEvent: ResizeEvent, dayViewContainer: HTMLElement): void {
295295
this.currentResize = {
296296
originalTop: event.top,
@@ -301,7 +301,7 @@ export class NovoCalendarDayViewElement implements OnChanges, OnInit, OnDestroy
301301
this.validateResize = ({rectangle}) => resizeHelper.validateResize({rectangle});
302302
this.cdr.detectChanges();
303303
}
304-
304+
305305
resizing(event: DayViewEvent, resizeEvent: ResizeEvent): void {
306306
if (resizeEvent.edges.top) {
307307
event.top = this.currentResize.originalTop + +resizeEvent.edges.top;
@@ -310,19 +310,19 @@ export class NovoCalendarDayViewElement implements OnChanges, OnInit, OnDestroy
310310
event.height = this.currentResize.originalHeight + +resizeEvent.edges.bottom;
311311
}
312312
}
313-
313+
314314
resizeEnded(dayEvent: DayViewEvent): void {
315-
315+
316316
let pixelsMoved: number;
317317
if (this.currentResize.edge === 'top') {
318318
pixelsMoved = (dayEvent.top - this.currentResize.originalTop);
319319
} else {
320320
pixelsMoved = (dayEvent.height - this.currentResize.originalHeight);
321321
}
322-
322+
323323
dayEvent.top = this.currentResize.originalTop;
324324
dayEvent.height = this.currentResize.originalHeight;
325-
325+
326326
const pixelAmountInMinutes: number = MINUTES_IN_HOUR / (this.hourSegments * SEGMENT_HEIGHT);
327327
const minutesMoved: number = pixelsMoved * pixelAmountInMinutes;
328328
let newStart: Date = dayEvent.event.start;
@@ -332,18 +332,18 @@ export class NovoCalendarDayViewElement implements OnChanges, OnInit, OnDestroy
332332
} else if (newEnd) {
333333
newEnd = addMinutes(newEnd, minutesMoved);
334334
}
335-
335+
336336
this.eventTimesChanged.emit({newStart, newEnd, event: dayEvent.event});
337337
this.currentResize = null;
338-
338+
339339
}
340-
340+
341341
dragStart(event: HTMLElement, dayViewContainer: HTMLElement): void {
342342
const dragHelper: CalendarDragHelper = new CalendarDragHelper(dayViewContainer, event);
343343
this.validateDrag = ({x, y}) => !this.currentResize && dragHelper.validateDrag({x, y});
344344
this.cdr.detectChanges();
345345
}
346-
346+
347347
eventDragged(dayEvent: DayViewEvent, draggedInPixels: number): void {
348348
const pixelAmountInMinutes: number = MINUTES_IN_HOUR / (this.hourSegments * SEGMENT_HEIGHT);
349349
const minutesMoved: number = draggedInPixels * pixelAmountInMinutes;

src/elements/calendar/week/CalendarWeekEvent.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ import { WeekViewEvent } from '../../../utils/calendar-utils/CalendarUtils';
1111
[class.cal-ends-within-week]="!weekEvent.endsAfterWeek"
1212
[ngClass]="weekEvent.event?.cssClass"
1313
[tooltip]="weekEvent.event.title"
14-
[tooltipPosition]="tooltipPosition">
14+
[tooltipPosition]="tooltipPosition"
15+
(click)="eventClicked.emit({event: weekEvent.event})">
1516
<div class="cal-event-ribbon" [style.backgroundColor]="weekEvent.event.color.primary"></div>
1617
<div class="cal-event-title">{{weekEvent.event?.title}}</div>
1718
<div class="cal-event-description">{{weekEvent.event?.description}}</div>

src/elements/calendar/week/CalendarWeekView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const MINUTES_IN_HOUR: number = 60;
7171
[weekEvent]="weekEvent"
7272
[tooltipPosition]="tooltipPosition"
7373
[customTemplate]="eventTemplate"
74-
(eventClicked)="eventClicked.emit({event: weekEvent.event})">
74+
(eventClicked)="eventClicked.emit($event)">
7575
</novo-calendar-week-event>
7676
</div>
7777
</div>

0 commit comments

Comments
 (0)