fix(MetaService): Address a caching issue (#105)

Address an issue where fetching a viewlayout would reduce the contents of the cache

Update github workflow cache to v4

Author: davidkbh

.github/workflows/main.yaml

@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v1
 
       - name: Cache node modules
-        uses: actions/cache@v1
+        uses: actions/cache@v4
         with:
           path: ~/.npm
           key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

src/services/MetaService.ts

@@ -240,16 +240,23 @@ export class MetaService {
     if (result && result.sectionHeaders) {
       this.sectionHeaders = result.sectionHeaders;
     }
-    result.fields = keepFieldsFromLayout ? result.fields : this.fields;
     result.layouts = this.layouts;
     result.trackTrigger = this.trackTrigger;
     result.tracks = this.tracks;
     result.sectionHeaders = this.sectionHeaders;
 
     result.allFieldsLoaded = result.allFieldsLoaded || this.allFieldsLoaded;
     this.allFieldsLoaded = result.allFieldsLoaded;
-    // tslint:disable-next-line:no-floating-promises
-    Cache.put(this.endpoint, result);
+    if (keepFieldsFromLayout) {
+      // Save cache as separate object
+      const cacheResult = { ...result, fields: this.fields };
+      // tslint:disable-next-line:no-floating-promises
+      Cache.put(this.endpoint, cacheResult);
+    } else {
+      result.fields = this.fields;
+      // tslint:disable-next-line:no-floating-promises
+      Cache.put(this.endpoint, result);
+    }
   }
 
   private missing(fields): string[] {