Merge branch 'main' into money-validator

Author: bumblecoder

.github/workflows/test.yml

@@ -0,0 +1,42 @@
+name: Run Tests
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.2
+          extensions: mysqli
+
+      - name: Install Composer dependencies
+        working-directory: ./code
+        run: composer install --prefer-dist --no-progress
+
+      - name: Copy .env.example to .env
+        working-directory: ./code
+        run: cp .env.example .env
+
+      - name: Generate app key
+        working-directory: ./code
+        run: php artisan key:generate
+
+      - name: Run database migrations
+        working-directory: ./code
+        run: php artisan migrate
+
+      - name: Run tests
+        working-directory: ./code
+        run: vendor/bin/phpunit

README.md

@@ -15,8 +15,8 @@ Ensure you have Docker and Docker Compose installed on your machine.
 
 1. Clone the repo
    ```sh
-   git clone https://github.com/bumblecoder/tech-task.git
-   cd tech-task
+   git clone git@github.com:bumblecoder/tech-task-pay.git
+   cd tech-task-pay
    cp code/.env.example code/.env
    ```
 2. Build and start the Docker containers:

code/app/Services/RequestMoneyValidator.php

@@ -12,13 +12,18 @@
 {
     public function __construct(private int $deviation)
     {
-        if ($deviation < 0 || $deviation > 100) {
-            throw new InvalidArgumentException('Deviation must be between 0 and 100.');
-        }
     }
 
     public function validate(Request $request, Transaction $transaction): bool
     {
+        if (!filter_var(
+            $this->deviation,
+            FILTER_VALIDATE_INT,
+            ['options' => ['min_range' => 0, 'max_range' => 100]]
+        )) {
+            throw new InvalidArgumentException('Deviation must be between 0 and 100.');
+        }
+
         if ($request->getCurrency() !== $transaction->getCurrency()) {
             return false;
         }

code/config/app.php

@@ -123,5 +123,5 @@
         'store' => env('APP_MAINTENANCE_STORE', 'database'),
     ],
 
-    'transaction_deviation' => env('TRANSACTION_DEVIATION', 5),
+    'transaction_deviation' => (int) env('TRANSACTION_DEVIATION', 5),
 ];

code/tests/Feature/ExampleTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature;
+
+use Tests\TestCase;
+
+class TransactionControllerTest extends TestCase
+{
+    public function test_validate_transaction_success(): void
+    {
+        $response = $this->getJson('/validate-transaction');
+
+        $response->assertStatus(200)
+            ->assertJson(['isValid' => false]);
+    }
+
+    public function test_validate_transaction_invalid_deviation(): void
+    {
+        config(['app.transaction_deviation' => 150]);
+
+        $response = $this->getJson('/validate-transaction');
+
+        $response->assertStatus(400)
+            ->assertJson([
+                'error' => 'Validation failed',
+                'message' => 'Deviation must be between 0 and 100.'
+            ]);
+    }
+}

code/tests/Feature/TransactionControllerTest.php

@@ -45,8 +45,7 @@ public function test_validate_exact_amount(): void
     {
         $request = Request::create(10000, 'USD');
         $transaction = Transaction::create(10000, 'USD');
-
-        $validator = new RequestMoneyValidator(0);
+        $validator = new RequestMoneyValidator(10);
 
         $this->assertTrue($validator->validate($request, $transaction));
     }
@@ -66,6 +65,10 @@ public function test_negative_deviation_throws_exception(): void
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('Deviation must be between 0 and 100.');
 
+        $request = Request::create(10000, 'USD');
+        $transaction = Transaction::create(9000, 'USD');
         $validator = new RequestMoneyValidator(-5);
+
+        $validator->validate($request, $transaction);
     }
 }