Skip to content

Commit a5f614a

Browse files
authored
Merge pull request #776 from paulRbr/diff-overlays
diff: change core run signature to allow TWO overlays list
2 parents 9abaa13 + 0f58626 commit a5f614a

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/core/diff.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,13 @@ export class Diff {
3333
file1: string,
3434
file2: string,
3535
expires: string | undefined,
36-
overlays?: string[] | undefined,
36+
overlays1?: string[] | undefined,
37+
overlays2?: string[] | undefined,
3738
): Promise<DiffResponse | undefined> {
3839
const api = await API.load(file1)
39-
const [previous_definition, previous_references] = await api.extractDefinition(undefined, overlays)
40+
const [previous_definition, previous_references] = await api.extractDefinition(undefined, overlays1)
4041
const api2 = await API.load(file2)
41-
const [definition, references] = await api2.extractDefinition(undefined, overlays)
42+
const [definition, references] = await api2.extractDefinition(undefined, overlays2 || overlays1)
4243
const request: DiffRequest = {
4344
definition,
4445
expires_at: expires,
@@ -140,21 +141,22 @@ export class Diff {
140141
branch: string | undefined,
141142
token: string | undefined,
142143
format: string,
143-
expires: string | undefined,
144-
overlays: string[] | undefined,
144+
expires?: string | undefined,
145+
overlays1?: string[] | undefined,
146+
overlays2?: string[] | undefined,
145147
): Promise<DiffResponse | undefined> {
146148
if (!this._config) this._config = await Config.load(resolve(import.meta.dirname, './../../'))
147149

148150
let diffVersion: DiffResponse | VersionResponse | undefined
149151

150152
if (file2 && (!documentation || !token)) {
151-
diffVersion = await this.createDiff(file1, file2, expires, overlays)
153+
diffVersion = await this.createDiff(file1, file2, expires, overlays1, overlays2)
152154
} else {
153155
if (!documentation || !token) {
154156
throw new Error('Please login to bump (with documentation & token) when using a single file argument')
155157
}
156158

157-
diffVersion = await this.createVersion(file1, documentation, token, hub, branch, undefined, overlays)
159+
diffVersion = await this.createVersion(file1, documentation, token, hub, branch, undefined, overlays1)
158160

159161
if (file2) {
160162
diffVersion = await this.createVersion(
@@ -164,7 +166,7 @@ export class Diff {
164166
hub,
165167
branch,
166168
diffVersion && diffVersion.id,
167-
overlays,
169+
overlays2 || overlays1,
168170
)
169171
}
170172
}

0 commit comments

Comments
 (0)