Skip to content

Commit dbd0f7a

Browse files
committed
fix(deploy): no need for quoting around filename_pattern input val
Not sur why I added some quotes around the newly introduced `filename_pattern` input, as we don't quote any of the other input values. This led to a bug of double single quotes, thus the default pattern for the GH action to be the litteral `'{slug}-api'` (with the single quotes). Sorry for that!
1 parent 590e36a commit dbd0f7a

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/main.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,7 @@ export async function run(): Promise<void> {
3737
if (hub) {
3838
deployParams = deployParams.concat(['--auto-create', '--hub', hub]);
3939
if (filenamePattern) {
40-
deployParams = deployParams.concat([
41-
'--filename-pattern',
42-
`'${filenamePattern}'`,
43-
]);
40+
deployParams = deployParams.concat(['--filename-pattern', filenamePattern]);
4441
}
4542
}
4643

tests/main.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ describe('main.ts', () => {
8686
'--hub',
8787
'my-hub',
8888
'--filename-pattern',
89-
"'source-{slug}-*'",
89+
'source-{slug}-*',
9090
],
9191
'.',
9292
);

0 commit comments

Comments
 (0)