fix const naming [#20]

Author: dnl-blkv

bunq/sdk/client.py

@@ -393,10 +393,10 @@ class Pagination(object):
     _ERROR_NO_PREVIOUS_PAGE = 'Could not generate previous page URL params: ' \
                               'there is no previous page.'
 
-    # Field constants
-    FIELD_OLDER_ID = 'older_id'
-    FIELD_NEWER_ID = 'newer_id'
-    FIELD_COUNT = 'count'
+    # URL Param constants
+    URL_PARAM_OLDER_ID = 'older_id'
+    URL_PARAM_NEWER_ID = 'newer_id'
+    URL_PARAM_COUNT = 'count'
 
     def __init__(self):
         self._older_id = None
@@ -415,7 +415,7 @@ def url_params_previous_page(self):
             raise exception.BunqException(self._ERROR_NO_PREVIOUS_PAGE)
 
         params = {
-            self.FIELD_OLDER_ID: str(self._older_id),
+            self.URL_PARAM_OLDER_ID: str(self._older_id),
         }
         self._add_count_to_params_if_needed(params)
 
@@ -436,7 +436,7 @@ def _add_count_to_params_if_needed(self, params):
         """
 
         if self._count is not None:
-            params[self.FIELD_COUNT] = str(self._count)
+            params[self.URL_PARAM_COUNT] = str(self._count)
 
     @property
     def _next_id(self):
@@ -463,7 +463,7 @@ def url_params_next_page(self):
         """
 
         params = {
-            self.FIELD_NEWER_ID: str(self._next_id),
+            self.URL_PARAM_NEWER_ID: str(self._next_id),
         }
         self._add_count_to_params_if_needed(params)
 

bunq/sdk/json/adapters.py

@@ -488,21 +488,21 @@ def parse_pagination_dict(cls, response_obj):
             cls._FIELD_OLDER_ID,
             response_obj,
             cls._FIELD_OLDER_URL,
-            client.Pagination.FIELD_OLDER_ID
+            client.Pagination.URL_PARAM_OLDER_ID
         )
         cls.update_dict_id_field_from_response_field(
             pagination_dict,
             cls._FIELD_NEWER_ID,
             response_obj,
             cls._FIELD_NEWER_URL,
-            client.Pagination.FIELD_NEWER_ID
+            client.Pagination.URL_PARAM_NEWER_ID
         )
         cls.update_dict_id_field_from_response_field(
             pagination_dict,
             cls._FIELD_FUTURE_ID,
             response_obj,
             cls._FIELD_FUTURE_URL,
-            client.Pagination.FIELD_NEWER_ID
+            client.Pagination.URL_PARAM_NEWER_ID
         )
 
         return pagination_dict
@@ -530,7 +530,8 @@ def update_dict_id_field_from_response_field(cls, dict_, dict_id_field,
 
             if cls._FIELD_COUNT in parameters:
                 dict_[cls._FIELD_COUNT] = int(
-                    parameters[client.Pagination.FIELD_COUNT][cls._INDEX_FIRST]
+                    parameters[client.Pagination.URL_PARAM_COUNT][
+                        cls._INDEX_FIRST]
                 )
 
     @classmethod