Reflected PHP review changes.

Author: Kevin Hellemun

bunq/sdk/client.py

@@ -15,6 +15,16 @@ class ApiClient(object):
     :type _api_context: bunq.sdk.context.ApiContext
     """
 
+    # Endpoints not requiring active session for the request to succeed.
+    _URL_DEVICE_SERVER = 'device-server'
+    _URI_INSTALLATION = 'installation'
+    _URI_SESSION_SERVER = 'session-server'
+    _URIS_NOT_REQUIRING_ACTIVE_SESSION = [
+        _URI_INSTALLATION,
+        _URI_SESSION_SERVER,
+        _URL_DEVICE_SERVER,
+    ]
+
     # HTTPS type of proxy, the only used at bunq
     _FIELD_PROXY_HTTPS = 'https'
 
@@ -93,7 +103,8 @@ def _request(self, method, uri_relative, request_bytes, params,
 
         uri_relative_with_params = self._append_params_to_uri(uri_relative,
                                                               params)
-        self._api_context.ensure_session_active()
+        if uri_relative not in self._URIS_NOT_REQUIRING_ACTIVE_SESSION:
+            self._api_context.ensure_session_active()
         all_headers = self._get_all_headers(
             method,
             uri_relative_with_params,

bunq/sdk/context.py

@@ -166,10 +166,14 @@ def _get_session_timeout_seconds(cls, session_server):
             return session_server.user_person.session_timeout
 
     def ensure_session_active(self):
-        if self.is_session_expired() and self.session_context is not None:
+        """
+        Resets the session if it has expired.
+        """
+
+        if not self.is_session_active():
             self.reset_session()
 
-    def is_session_expired(self):
+    def is_session_active(self):
         """
         :return: True if it has expired, otherwise false
         :rtype: bool
@@ -184,7 +188,7 @@ def is_session_expired(self):
             seconds=self._TIME_TO_SESSION_EXPIRY_MINIMUM_SECONDS
         )
 
-        return time_to_expiry < time_to_expiry_minimum
+        return time_to_expiry > time_to_expiry_minimum
 
     def reset_session(self):
         """