Wrap unit test calls to set_var in unsafe {}

Newer rustc's complain about it, previous ones didn't 🤷

Author: rtyler

cli/src/main.rs

@@ -75,7 +75,9 @@ mod tests {
         let mut flags = Flags::default();
         flags.table = None;
 
-        std::env::set_var("TABLE_LOCATION", "s3://test-bucket-from-env/table");
+        unsafe {
+            std::env::set_var("TABLE_LOCATION", "s3://test-bucket-from-env/table");
+        }
 
         let location = table_location(&flags).expect("Failed to load table location");
         assert_eq!(location, "s3://test-bucket-from-env/table");

crates/oxbow/src/lib.rs

@@ -476,7 +476,7 @@ fn coerce_field(
             let coerced = coerce_field(field.clone());
             let list_field = Field::new(field.name(), DataType::List(coerced), field.is_nullable());
             return Arc::new(list_field);
-        },
+        }
         DataType::Struct(fields) => {
             let coerced: Vec<deltalake::arrow::datatypes::FieldRef> =
                 fields.iter().map(|f| coerce_field(f.clone())).collect();
@@ -486,7 +486,7 @@ fn coerce_field(
                 field.is_nullable(),
             );
             return Arc::new(struct_field);
-        },
+        }
         _ => {}
     };
     field.clone()
@@ -832,7 +832,9 @@ mod tests {
     #[tokio::test]
     async fn attempt_to_convert_without_auth() {
         let region = std::env::var("AWS_REGION");
-        std::env::set_var("AWS_REGION", "custom");
+        unsafe {
+            std::env::set_var("AWS_REGION", "custom");
+        }
         deltalake::aws::register_handlers(None);
 
         let files: Vec<ObjectMeta> = vec![];
@@ -847,7 +849,9 @@ mod tests {
         assert!(result.is_err());
 
         if let Ok(region) = region {
-            std::env::set_var("AWS_REGION", region);
+            unsafe {
+                std::env::set_var("AWS_REGION", region);
+            }
         }
     }
 

lambdas/glue-sync/src/main.rs

@@ -389,10 +389,12 @@ mod tests {
             records: vec![message],
         };
         let lambda_event = LambdaEvent::new(event, lambda_runtime::Context::default());
-        std::env::set_var(
-            GLUE_REGEX_ENV,
-            r#"(?P<database>\w+)\/(?P<table>\w+)\/_delta_log\/.*.json"#,
-        );
+        unsafe {
+            std::env::set_var(
+                GLUE_REGEX_ENV,
+                r#"(?P<database>\w+)\/(?P<table>\w+)\/_delta_log\/.*.json"#,
+            );
+        }
         let result = function_handler(lambda_event).await;
         assert!(result.is_ok());
     }