Skip to content

Commit b9d5856

Browse files
committed
^ Selecting of packages in full outdated package display
1 parent 5ff724f commit b9d5856

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

Cork/Localizable.xcstrings

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48848,13 +48848,13 @@
4884848848
"one" : {
4884948849
"stringUnit" : {
4885048850
"state" : "translated",
48851-
"value" : "There is 1 additional package that’s opted out of Homebrew’s updating mechanism"
48851+
"value" : "There is 1 additional package not managed by Homebrew"
4885248852
}
4885348853
},
4885448854
"other" : {
4885548855
"stringUnit" : {
4885648856
"state" : "translated",
48857-
"value" : "There are %lld additional packages that are opted out of Homebrew’s updating mechanism"
48857+
"value" : "There are %lld additional packages not managed by Homebrew"
4885848858
}
4885948859
}
4886048860
}

Cork/Views/Start Page/Sub-Views/Outdated Packages/Outdated Package List Box.swift

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ struct OutdatedPackageListBox: View
1616
@EnvironmentObject var outdatedPackageTracker: OutdatedPackageTracker
1717

1818
@Binding var isDropdownExpanded: Bool
19-
19+
2020
@State private var isSelfUpdatingSectionExpanded: Bool = false
2121

2222
private var packagesMarkedForUpdating: [OutdatedPackage]
@@ -61,6 +61,10 @@ struct OutdatedPackageListBox: View
6161
} label: {
6262
Text("start-page.updates.action")
6363
}
64+
65+
#if DEBUG
66+
Text(String(packagesMarkedForUpdating.count))
67+
#endif
6468
}
6569
else
6670
{
@@ -80,7 +84,8 @@ struct OutdatedPackageListBox: View
8084

8185
if !packagesThatUpdateThemselves.isEmpty
8286
{
83-
DisclosureGroup(isExpanded: $isSelfUpdatingSectionExpanded) {
87+
DisclosureGroup(isExpanded: $isSelfUpdatingSectionExpanded)
88+
{
8489
outdatedPackageListComplex(packagesToShow: packagesThatUpdateThemselves)
8590
} label: {
8691
Text("start-page.updates.self-updating.\(packagesThatUpdateThemselves.count).list")
@@ -238,7 +243,8 @@ struct OutdatedPackageListBox: View
238243
{ outdatedPackage in
239244
Toggle(isOn: Binding<Bool>(
240245
get: {
241-
outdatedPackage.isMarkedForUpdating
246+
/// This was vibe-coded. It fixes the problem, but I have no idea why.
247+
outdatedPackageTracker.outdatedPackages.contains(where: { $0.id == outdatedPackage.id && $0.isMarkedForUpdating })
242248
}, set: { toggleState in
243249
outdatedPackageTracker.outdatedPackages = Set(outdatedPackageTracker.outdatedPackages.map
244250
{ modifiedElement in

0 commit comments

Comments
 (0)