center the "edit start time" button on the screen (#166)

frontend development is so annoyingly hard sometimes

this also clears "is-invalid" styling on an element when
"is-valid" styling is added

Author: srabraham

web/static/ims.js

@@ -278,10 +278,12 @@ export function unhide(selector) {
 }
 // Add an error indication to a control
 export function controlHasError(element) {
+    element.classList.remove("is-valid");
     element.classList.add("is-invalid");
 }
 // Add a success indication to a control
 export function controlHasSuccess(element, clearTimeout) {
+    element.classList.remove("is-invalid");
     element.classList.add("is-valid");
     if (clearTimeout != null) {
         setTimeout(() => {

web/template/incident.templ

@@ -102,9 +102,11 @@ templ Incident(deployment string) {
           <label class="control-label input-group-text" for="started_datetime">Created</label>
           <span class="form-control form-control-static align-middle d-flex justify-content-between">
             <span id="started_datetime"></span>
-            <svg id="override_started_button" fill="currentColor" class="bi align-middle show-pointer">
-              <use href="#pencil-square" />
-            </svg>
+            <span class="show-pointer">
+              <svg id="override_started_button" fill="currentColor" class="bi align-middle">
+                <use href="#pencil-square" />
+              </svg>
+            </span>
           </span>
         </div>
       </div>

web/template/incident_templ.go

@@ -316,12 +316,14 @@ export function unhide(selector: string): void {
 
 // Add an error indication to a control
 export function controlHasError(element: HTMLElement) {
+    element.classList.remove("is-valid");
     element.classList.add("is-invalid");
 }
 
 
 // Add a success indication to a control
 export function controlHasSuccess(element: HTMLElement, clearTimeout: number) {
+    element.classList.remove("is-invalid");
     element.classList.add("is-valid");
     if (clearTimeout != null) {
         setTimeout(()=>{