Skip to content

Commit 2d95aad

Browse files
committed
ci: clean up workflows
Clean up the workflows, set required parameters, and align with our coding style. Signed-off-by: David Rheinsberg <david@readahead.eu>
1 parent 4c26d18 commit 2d95aad

File tree

5 files changed

+42
-18
lines changed

5 files changed

+42
-18
lines changed
Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,29 @@
66
# latest version.
77
#
88

9-
name: "CI for Custom Actions"
9+
name: "Custom Action Tests"
1010

11-
on: [pull_request, push]
11+
on:
12+
pull_request:
13+
push:
14+
branches-ignore: ["pr/**"]
15+
tags: ["**"]
16+
workflow_dispatch:
17+
18+
defaults:
19+
run:
20+
shell: "bash"
1221

1322
jobs:
14-
ci_msdevshell_testing:
23+
msdevshell_testing:
1524
name: "Test the MsDevShell Action"
16-
runs-on: ${{ matrix.os }}
25+
1726
strategy:
1827
matrix:
19-
arch: [x64, x86]
20-
os: [windows-2019, windows-latest]
28+
arch: ["x64", "x86"]
29+
os: ["windows-2019", "windows-latest"]
2130

31+
runs-on: ${{ matrix.os }}
2232

2333
steps:
2434
- name: "Clone Repository"
@@ -32,9 +42,9 @@ jobs:
3242
- name: "Verify MsDevShell"
3343
run: cl
3444

35-
ci_msdevshell_release:
45+
msdevshell_release:
3646
name: "Verify the MsDevShell Action Release"
37-
runs-on: windows-latest
47+
runs-on: "windows-latest"
3848

3949
steps:
4050
- name: "Run released MsDevShell action"

.github/workflows/ci-c-util.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ on:
5858
required: false
5959
type: boolean
6060

61+
defaults:
62+
run:
63+
shell: "bash"
64+
6165
jobs:
6266

6367
config:

.github/workflows/ci-sphinx.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ on:
2828
required: false
2929
type: string
3030

31+
defaults:
32+
run:
33+
shell: "bash"
34+
3135
jobs:
3236

3337
sphinx:

.github/workflows/containers.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ name: "Container Images"
1313

1414
on:
1515
pull_request:
16-
branches: ["main"]
1716
paths:
1817
- ".github/workflows/containers.yml"
1918
- "lib/containers/**"
2019
push:
21-
branches: ["main", "wip/**"]
20+
branches-ignore: ["pr/**"]
21+
tags: ["**"]
2222
paths:
2323
- ".github/workflows/containers.yml"
2424
- "lib/containers/**"
Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,33 @@
11
#
2-
# GitHub-Actions Linters
2+
# Linter Checks
33
#
44
# This workflow runs code linters on the entire code-base. Different kind of
55
# linters for different sources are available.
66
#
77

8-
name: "Linter checks"
8+
name: "Linter Checks"
99

1010
on:
1111
pull_request:
12-
branches: [main]
12+
push:
13+
branches-ignore: ["pr/**"]
14+
tags: ["**"]
15+
workflow_dispatch:
1316

14-
permissions:
15-
contents: read
17+
defaults:
18+
run:
19+
shell: "bash"
1620

1721
jobs:
18-
ci_shellcheck:
22+
shellcheck:
1923
name: "Differential ShellCheck"
20-
runs-on: ubuntu-latest
2124

2225
permissions:
23-
security-events: write
26+
contents: read
2427
pull-requests: write
28+
security-events: write
29+
30+
runs-on: "ubuntu-latest"
2531

2632
steps:
2733
- name: "Clone Repository"

0 commit comments

Comments
 (0)