Skip to content

Commit 5c87a98

Browse files
committed
test: Comment out downgrade tests
They should compare on objects, not json
1 parent 2570622 commit 5c87a98

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

crates/buttplug_tests/tests/test_message_downgrades.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ use futures::{StreamExt, pin_mut};
2424
use util::test_server_with_device;
2525
use uuid::Uuid;
2626

27+
2728
#[tokio::test]
29+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
2830
async fn test_version0_connection() {
2931
let server = ButtplugServerBuilder::default().finish().unwrap();
3032
let serializer = ButtplugServerJSONSerializer::default();
@@ -44,6 +46,7 @@ async fn test_version0_connection() {
4446
}
4547

4648
#[tokio::test]
49+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
4750
async fn test_version2_connection() {
4851
let server = ButtplugServerBuilder::default().finish().unwrap();
4952
let serializer = ButtplugServerJSONSerializer::default();
@@ -64,6 +67,7 @@ async fn test_version2_connection() {
6467
}
6568

6669
#[tokio::test]
70+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
6771
async fn test_version0_device_added_device_list() {
6872
let (server, _) = test_server_with_device("Massage Demo");
6973
let recv = server.event_stream();
@@ -114,6 +118,7 @@ async fn test_version0_device_added_device_list() {
114118
}
115119

116120
#[tokio::test]
121+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
117122
async fn test_version0_singlemotorvibratecmd() {
118123
tracing_subscriber::fmt::init();
119124
let (server, mut device) = test_server_with_device("Massage Demo");
@@ -180,6 +185,7 @@ async fn test_version0_singlemotorvibratecmd() {
180185
}
181186

182187
#[tokio::test]
188+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
183189
async fn test_version1_singlemotorvibratecmd() {
184190
let (server, mut device) = test_server_with_device("Massage Demo");
185191
let recv = server.event_stream();
@@ -256,6 +262,7 @@ async fn test_version1_singlemotorvibratecmd() {
256262
}
257263

258264
#[tokio::test]
265+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
259266
async fn test_version0_oscillatoronly() {
260267
let (server, mut _device) = test_server_with_device("Xone");
261268
let recv = server.event_stream();
@@ -303,6 +310,7 @@ async fn test_version0_oscillatoronly() {
303310
}
304311

305312
#[tokio::test]
313+
#[ignore="This isn't how to test equality in downgrades, we shouldn't use serialized versions"]
306314
async fn test_version1_oscilatoronly() {
307315
let (server, mut _device) = test_server_with_device("Xone");
308316
let recv = server.event_stream();

0 commit comments

Comments
 (0)