fix: Correct oscillation range SolacePro

Unlike the second hardware release of the original Solace, the SolacePro doesn't need/like the range being set to 0 on stop (it causes a shudder)

Author: blackspherefollower

crates/buttplug_server/src/device/protocol_impl/lovense/lovense_stroker.rs

@@ -29,16 +29,17 @@ const LOVENSE_STROKER_PROTOCOL_UUID: Uuid = uuid!("a97fc354-5561-459a-bc62-110d7
 
 pub struct LovenseStroker {
   linear_info: Arc<(AtomicU32, AtomicU32)>,
+  need_range_zerod: bool,
 }
 
 impl LovenseStroker {
-  pub fn new(hardware: Arc<Hardware>) -> Self {
+  pub fn new(hardware: Arc<Hardware>, need_range_zerod: bool) -> Self {
     let linear_info = Arc::new((AtomicU32::new(0), AtomicU32::new(0)));
     async_manager::spawn(update_linear_movement(
       hardware.clone(),
       linear_info.clone(),
     ));
-    Self { linear_info }
+    Self { linear_info, need_range_zerod }
   }
 }
 
@@ -79,7 +80,7 @@ impl ProtocolHandler for LovenseStroker {
       HardwareWriteCmd::new(
         &[feature_id],
         Endpoint::Tx,
-        format!("Mply:{}:{};", speed, if speed == 0 { 0 } else { 20 })
+        format!("Mply:{}:{};", speed, if speed == 0 && self.need_range_zerod { 0 } else { 20 })
           .as_bytes()
           .to_vec(),
         false,

crates/buttplug_server/src/device/protocol_impl/lovense/mod.rs

@@ -245,7 +245,7 @@ impl ProtocolInitializer for LovenseInitializer {
     );
 
     if device_type == "BA" || device_type == "H" {
-      Ok(Arc::new(LovenseStroker::new(hardware)))
+      Ok(Arc::new(LovenseStroker::new(hardware, device_type == "H")))
     } else if output_count == 1 {
       Ok(Arc::new(LovenseSingleActuator::default()))
     } else if lovense_max {

examples/src/bin/device_tester.rs

@@ -146,15 +146,6 @@ async fn device_tester() {
           dev.index(),
           feature.feature_index()
         );
-      } else if let Some(out) = outs.get(OutputType::Position) {
-        cmds.push(feature.position(out.step_count()));
-        println!(
-          "{} ({}) should start moving to position {} on feature {}!",
-          dev.name(),
-          dev.index(),
-          out.step_count(),
-          feature.feature_index()
-        );
       }
     });
     if cmds.len() > 0 {
@@ -214,14 +205,6 @@ async fn device_tester() {
             dev.index(),
             feature.feature_index()
           );
-        } else if outs.get(OutputType::Position).is_some() {
-          cmds.push(feature.position(0));
-          println!(
-            "{} ({}) should start moving to position 0 on feature {}!",
-            dev.name(),
-            dev.index(),
-            feature.feature_index()
-          );
         }
       });