ignoreCase: private structs with single interface

[cardil]

Returning private structs, as this linter advises, is cumbersome to the caller. They are private for a reason, so a caller should be interested only in behavior (interface).

Linter should allow returning public interface instead of private type with single interface.

Also, worth adding that returning private structs is considered an error by revive linter.

Implementing this will likely resolve #21

[butuzov]

Make sense to me. I will implement this check soon.

P/S/
The only case when it doesn't its internal usage (the interface used locally within the package ).

[nawa]

This should be controlled by a flag

I use this feature returning a private struct and use its interface on the client side. It is common approach when you declare interfaces on the client side

client.go

package client

import "impl"

type IFace interface {
    Do()
}

instance := impl.New()

impl.go

package impl



type privateImpl struct {
}

func (*privateImpl) Do() {
}

func New() *privateImpl {
  return &privateImpl{}
}

[butuzov]

@nava do you use this linter as it is or a part of golangci-lint ?

[nawa]

@nava do you use this linter as it is or a part of golangci-lint ?

Yes, of course

[butuzov]

Сергей, вы не поняли мой вопрос: вы используете ireturn в стендалон режиме (как отдельную бинарную программу илиже в составе golangci-lint?

[nawa]

Я все правильно понял - "да, конечно" в составе golangci-lint