feat: add ForceERPSyncOnStart configuration and update cron job behavior based on ERP integration

Author: buzyka

cmd/app/main.go

@@ -33,7 +33,7 @@ func main() {
 	gocontainer.Build(&cfg)
 
 	// Start cron jobs
-	stopCron, err := cron.RunCron()
+	stopCron, err := cron.RunCron(&cfg)
 	if err != nil {
 		panic(fmt.Sprintf("Error starting cron jobs: %v\n", err))
 	}

internal/config/config.go

@@ -30,6 +30,8 @@ type Config struct {
 
 	AutoRegistrationYearGroups []int32 `env:"AUTO_REGISTRATION_YEAR_GROUPS" envSeparator:","`
 
+	ForceERPSyncOnStart bool `env:"FORCE_ERP_SYNC_ON_START" envDefault:"false"`
+
 	erpLocation *time.Location
 	appLocation *time.Location
 }
@@ -118,3 +120,7 @@ func (c *Config) ERPTimeLocation() *time.Location {
 func (c *Config) APPTimeLocation() *time.Location {
 	return c.appLocation
 }
+
+func (c *Config) IsERPIntegrated() bool {
+	return c.ISAMSBaseURL != "" && c.ISAMSAPIClientID != "" && c.ISAMSAPIClientSecret != ""
+}

internal/config/config_test.go

@@ -215,6 +215,41 @@ func TestNewFromEnv_AutoRegistrationYearGroups(t *testing.T) {
 	assert.Equal(t, []int32{6, 7, 8}, cfg.AutoRegistrationYearGroups)
 }
 
+func TestNewFromEnv_ForceERPSyncOnStart(t *testing.T) {
+	tests := []struct {
+		name     string
+		envValue string
+		expected bool
+	}{
+		{
+			name:     "true value",
+			envValue: "true",
+			expected: true,
+		},
+		{
+			name:     "false value",
+			envValue: "false",
+			expected: false,
+		},
+		{
+			name:     "empty uses default false",
+			envValue: "",
+			expected: false,
+		},
+	}
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			loadTestEnvVariables(t, map[string]string{
+				"FORCE_ERP_SYNC_ON_START": tc.envValue,
+			})
+
+			cfg, err := NewFromEnv()
+			assert.NoError(t, err)
+			assert.Equal(t, tc.expected, cfg.ForceERPSyncOnStart)
+		})
+	}
+}
+
 func TestNewFromEnv_ParseError(t *testing.T) {
 	oldParse := parseEnv
 	parseEnv = func(_ interface{}, _ ...env.Options) error {
@@ -254,6 +289,57 @@ func TestGetDatabaseURLForMysqlFromEnv_ParseError(t *testing.T) {
 	assert.False(t, ok)
 }
 
+func TestIsERPIntegrated(t *testing.T) {
+	var tests = []struct {
+		name           string
+		newEnv         map[string]string
+		expectedResult bool
+	}{
+		{
+			name: "all required variables are set",
+			newEnv: map[string]string{
+				"ISAMS_BASE_URL":          "https://example.com",
+				"ISAMS_API_CLIENT_ID":     "client-id",
+				"ISAMS_API_CLIENT_SECRET": "client-secret",
+			},
+			expectedResult: true,
+		},
+		{
+			name: "missing ISAMS_BASE_URL",
+			newEnv: map[string]string{
+				"ISAMS_API_CLIENT_ID":     "client-id",
+				"ISAMS_API_CLIENT_SECRET": "client-secret",
+			},
+			expectedResult: false,
+		},
+		{
+			name: "missing ISAMS_API_CLIENT_ID",
+			newEnv: map[string]string{
+				"ISAMS_BASE_URL":          "https://example.com",
+				"ISAMS_API_CLIENT_SECRET": "client-secret",
+			},
+			expectedResult: false,
+		},
+		{
+			name: "missing ISAMS_API_CLIENT_SECRET",
+			newEnv: map[string]string{
+				"ISAMS_BASE_URL":      "https://example.com",
+				"ISAMS_API_CLIENT_ID": "client-id",
+			},
+			expectedResult: false,
+		},
+	}
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			loadTestEnvVariables(t, tc.newEnv)
+
+			cfg, err := NewFromEnv()
+			assert.NoError(t, err)
+			assert.Equal(t, tc.expectedResult, cfg.IsERPIntegrated())
+		})
+	}
+}
+
 func loadTestEnvVariables(t *testing.T, env map[string]string) {
 	t.Helper()
 	resetConfigEnv(t)
@@ -281,6 +367,7 @@ func resetConfigEnv(t *testing.T) {
 		"STUDENTS_IMAGE_PHOTO_DIR",
 		"STUDENTS_IMAGE_PHOTO_URL_PREFIX",
 		"AUTO_REGISTRATION_YEAR_GROUPS",
+		"FORCE_ERP_SYNC_ON_START",
 		"DATABASE_HOST",
 		"DATABASE_PORT",
 		"DATABASE_USERNAME",

internal/infrastructure/cron/cron_manager.go

@@ -16,13 +16,17 @@ type JobFunction func()
 
 type StopCronFunc = func()
 
-func RunCron() (StopCronFunc, error) {
+func RunCron(cfg *config.Config) (StopCronFunc, error) {
+	if !cfg.IsERPIntegrated() {
+		return func() {}, nil
+	}
+
 	s, err := gocron.NewScheduler()
 	if err != nil {
 		return nil, err
 	}
 
-	err = registerJobs(s)
+	err = registerJobs(s, cfg.ForceERPSyncOnStart)
 	if err != nil {
 		return nil, err
 	}
@@ -34,7 +38,7 @@ func RunCron() (StopCronFunc, error) {
 	}, nil
 }
 
-func registerJobs(s gocron.Scheduler) error {
+func registerJobs(s gocron.Scheduler, forceERPSyncOnStart bool) error {
 	// Student data sync job
 	_, err := s.NewJob(
 		gocron.CronJob(
@@ -87,11 +91,13 @@ func registerJobs(s gocron.Scheduler) error {
 	// You can register more cron jobs here
 	// ...
 
-	// one-time startup run, sequential
-	go func() {
-		StudentSyncFunc()()
-		StudentPhotosSyncFunc()()
-	}()
+	// one-time startup run, sequential (only if forceERPSyncOnStart is enabled)
+	if forceERPSyncOnStart {
+		go func() {
+			StudentSyncFunc()()
+			StudentPhotosSyncFunc()()
+		}()
+	}
 
 	return nil
 }

internal/infrastructure/cron/cron_manager_test.go

@@ -118,3 +118,67 @@ func TestMarkNotRegisteredStudentsAsAbsent_WithoutConfiguredYearGroups(t *testin
 	assert.Equal(t, 1, repo.optsLen)
 	assert.Empty(t, repo.yearGroups)
 }
+
+func TestRunCron_WhenERPNotIntegrated_ReturnsNoopAndNoError(t *testing.T) {
+	cfg := &config.Config{
+		ISAMSBaseURL:         "",
+		ISAMSAPIClientID:     "",
+		ISAMSAPIClientSecret: "",
+	}
+
+	stopFunc, err := RunCron(cfg)
+
+	assert.NoError(t, err)
+	assert.NotNil(t, stopFunc)
+	// Calling stop should not panic
+	stopFunc()
+}
+
+func TestRunCron_WhenERPIntegrated_ReturnsStopFuncAndNoError(t *testing.T) {
+	cfg := &config.Config{
+		ISAMSBaseURL:         "https://example.com",
+		ISAMSAPIClientID:     "client-id",
+		ISAMSAPIClientSecret: "client-secret",
+		ForceERPSyncOnStart:     false,
+	}
+
+	stopFunc, err := RunCron(cfg)
+
+	assert.NoError(t, err)
+	assert.NotNil(t, stopFunc)
+	stopFunc()
+}
+
+func TestRunCron_WhenERPIntegratedAndForceERPSyncOnStart_StartsWithoutError(t *testing.T) {
+	testContainer := container.New()
+	oldGlobal := container.Global
+	container.Global = testContainer
+	t.Cleanup(func() {
+		container.Global = oldGlobal
+	})
+
+	syncCalled := false
+	photosCalled := false
+
+	// Setup minimal container dependencies
+	container.MustSingleton(container.Global, func() *zap.SugaredLogger { return zap.NewNop().Sugar() })
+
+	cfg := &config.Config{
+		ISAMSBaseURL:         "https://example.com",
+		ISAMSAPIClientID:     "client-id",
+		ISAMSAPIClientSecret: "client-secret",
+		ForceERPSyncOnStart:     true,
+	}
+
+	// We can't easily test that goroutine runs without more complex setup
+	// but we can at least verify the function doesn't panic
+	stopFunc, err := RunCron(cfg)
+
+	assert.NoError(t, err)
+	assert.NotNil(t, stopFunc)
+	stopFunc()
+
+	// Verify the variables are unused (just to avoid linter warnings about unused variables)
+	_ = syncCalled
+	_ = photosCalled
+}