Optimized for loops in TfIdfSearchIndex search()

Brian Vaughn · Brian Vaughn · commit 91e15d82d0d4 · 2017-02-03T18:44:39.000-08:00
diff --git a/source/SearchIndex/TfIdfSearchIndex.js b/source/SearchIndex/TfIdfSearchIndex.js
@@ -84,12 +84,18 @@ export class TfIdfSearchIndex implements ISearchIndex {
       }
 
       if (i === 0) {
-        for (var uid in tokenMetadata.$uidMap) {
+        var keys = Object.keys(tokenMetadata.$uidMap);
+        for (var j = 0, numKeys = keys.length; j < numKeys; j++) {
+          var uid = keys[j];
+
           uidToDocumentMap[uid] = tokenMetadata.$uidMap[uid].$document;
         }
       } else {
-        for (var uid in uidToDocumentMap) {
-          if (!tokenMetadata.$uidMap[uid]) {
+        var keys = Object.keys(uidToDocumentMap);
+        for (var j = 0, numKeys = keys.length; j < numKeys; j++) {
+          var uid = keys[j];
+
+          if (!tokenMetadata.$uidMap.hasOwnProperty(uid)) {
             delete uidToDocumentMap[uid];
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -84,12 +84,18 @@ export class TfIdfSearchIndex implements ISearchIndex {`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`if (i === 0) {`
`87`		`- for (var uid in tokenMetadata.$uidMap) {`
	`87`	`+ var keys = Object.keys(tokenMetadata.$uidMap);`
	`88`	`+ for (var j = 0, numKeys = keys.length; j < numKeys; j++) {`
	`89`	`+ var uid = keys[j];`
	`90`	`+`
`88`	`91`	`uidToDocumentMap[uid] = tokenMetadata.$uidMap[uid].$document;`
`89`	`92`	`}`
`90`	`93`	`} else {`
`91`		`- for (var uid in uidToDocumentMap) {`
`92`		`- if (!tokenMetadata.$uidMap[uid]) {`
	`94`	`+ var keys = Object.keys(uidToDocumentMap);`
	`95`	`+ for (var j = 0, numKeys = keys.length; j < numKeys; j++) {`
	`96`	`+ var uid = keys[j];`
	`97`	`+`
	`98`	`+ if (!tokenMetadata.$uidMap.hasOwnProperty(uid)) {`
`93`	`99`	`delete uidToDocumentMap[uid];`
`94`	`100`	`}`
`95`	`101`	`}`