Merge pull request open-mpi#9932 from awlauria/fix_coverity_report

bwbarrett · web-flow · commit a9983888b297 · 2022-01-27T09:39:06.000-08:00
Coverity CID 1497862: Fix missing unlock in early return.
diff --git a/opal/mca/btl/base/btl_base_am_rdma.c b/opal/mca/btl/base/btl_base_am_rdma.c
@@ -1333,6 +1333,7 @@ int mca_btl_base_am_rdma_init(mca_btl_base_module_t *btl)
     if (NULL != btl->btl_am_data) {
         BTL_VERBOSE(("am_rdma_init: btl %p already initialized", (void *)btl));
         am_rdma_internal_fini(am_module);
+        opal_mutex_unlock(&default_component.mutex);
         return OPAL_SUCCESS;
     }
     opal_mutex_unlock(&default_component.mutex);

Original file line number	Diff line number	Diff line change
`@@ -1333,6 +1333,7 @@ int mca_btl_base_am_rdma_init(mca_btl_base_module_t *btl)`
`1333`	`1333`	`if (NULL != btl->btl_am_data) {`
`1334`	`1334`	`BTL_VERBOSE(("am_rdma_init: btl %p already initialized", (void *)btl));`
`1335`	`1335`	`am_rdma_internal_fini(am_module);`
	`1336`	`+ opal_mutex_unlock(&default_component.mutex);`
`1336`	`1337`	`return OPAL_SUCCESS;`
`1337`	`1338`	`}`
`1338`	`1339`	`opal_mutex_unlock(&default_component.mutex);`