Limit PHP Version

byjg · byjg · commit 7f14c9e1bdd2 · 2024-10-27T10:12:53.000-05:00
diff --git a/composer.json b/composer.json
@@ -14,7 +14,7 @@
   "prefer-stable": true,
   "minimum-stability": "dev",
   "require": {
-    "php": ">=8.1",
+    "php": ">=8.1 <8.4",
     "ext-dom": "*",
     "byjg/xmlutil": "^5.0",
     "byjg/serializer": "^5.0"
diff --git a/src/AnyDataset.php b/src/AnyDataset.php
@@ -238,8 +238,9 @@ public function removeRow(int|Row $row = null): void
         }
         if ($row instanceof Row) {
             $iPos = 0;
+            $rowArr = $row->toArray();
             foreach ($this->collection as $sr) {
-                if ($sr->toArray() == $row->toArray()) {
+                if ($sr->toArray() == $rowArr) {
                     $this->removeRow($iPos);
                     break;
                 }

Original file line number	Diff line number	Diff line change
`@@ -238,8 +238,9 @@ public function removeRow(int\|Row $row = null): void`
`238`	`238`	`}`
`239`	`239`	`if ($row instanceof Row) {`
`240`	`240`	`$iPos = 0;`
	`241`	`+ $rowArr = $row->toArray();`
`241`	`242`	`foreach ($this->collection as $sr) {`
`242`		`- if ($sr->toArray() == $row->toArray()) {`
	`243`	`+ if ($sr->toArray() == $rowArr) {`
`243`	`244`	`$this->removeRow($iPos);`
`244`	`245`	`break;`
`245`	`246`	`}`