Skip to content

Commit a467e51

Browse files
committed
Revert "Merge pull request #15 from fiksu/revert-to-v1.1.3"
This reverts commit d78d4e8, reversing changes made to 14f2c2a.
1 parent d78d4e8 commit a467e51

File tree

19 files changed

+277
-299
lines changed

19 files changed

+277
-299
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ cache: bundler
66

77
rvm:
88
- 1.9.3
9+
- 2.1.5
10+
911
before_script:
1012
- cp spec/dummy/config/database-sample.yml spec/dummy/config/database.yml; createdb bulk_data_methods_test
1113
script: bundle exec rake spec

Gemfile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
source 'https://rubygems.org'
22

3-
# NOTE(ahannon) Travis CI kindly requests that the debugger be split
4-
# out so that it does not install linecache during "bundle install":
5-
group :debug do
6-
gem 'debugger'
7-
end
8-
93
# Specify your gem's dependencies in bulk_data_methods.gemspec
104
gemspec

bulk_data_methods.gemspec

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ Gem::Specification.new do |s|
1515
s.require_path = 'lib'
1616
s.homepage = 'http://github.com/fiksu/bulk_data_methods'
1717
s.add_dependency "pg"
18-
s.add_dependency "activerecord", '>= 3.0.0', '< 4.0'
19-
s.add_development_dependency "rails", '>= 3.0.0', '< 4.0'
18+
s.add_dependency "activerecord", '>= 3.0', '< 5.0'
19+
s.add_development_dependency "rails", '>= 3.0', '< 5.0'
2020
s.add_development_dependency "rspec-rails"
21-
s.add_development_dependency "activeresource", '>= 3.0.0'
2221
end

lib/bulk_data_methods/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module BulkDataMethods
2-
VERSION = "1.1.3"
2+
VERSION = "2.0.0"
33
end

spec/bulk_data_methods/bulk_methods_mixin_spec.rb

Lines changed: 127 additions & 126 deletions
Large diffs are not rendered by default.

spec/dummy/config/application.rb

Lines changed: 4 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,65 +1,23 @@
11
require File.expand_path('../boot', __FILE__)
22

3-
# Pick the frameworks you want:
4-
require "active_record/railtie"
5-
require "action_controller/railtie"
6-
require "action_mailer/railtie"
7-
require "active_resource/railtie"
8-
require "sprockets/railtie"
9-
# require "rails/test_unit/railtie"
3+
require 'rails/all'
104

11-
Bundler.require
12-
require "bulk_data_methods"
5+
# Require the gems listed in Gemfile, including any gems
6+
# you've limited to :test, :development, or :production.
7+
Bundler.require(*Rails.groups)
138

149
module Dummy
1510
class Application < Rails::Application
1611
# Settings in config/environments/* take precedence over those specified here.
1712
# Application configuration should go into files in config/initializers
1813
# -- all .rb files in that directory are automatically loaded.
1914

20-
# Custom directories with classes and modules you want to be autoloadable.
21-
# config.autoload_paths += %W(#{config.root}/extras)
22-
23-
# Only load the plugins named here, in the order given (default is alphabetical).
24-
# :all can be used as a placeholder for all plugins not explicitly named.
25-
# config.plugins = [ :exception_notification, :ssl_requirement, :all ]
26-
27-
# Activate observers that should always be running.
28-
# config.active_record.observers = :cacher, :garbage_collector, :forum_observer
29-
3015
# Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
3116
# Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
3217
# config.time_zone = 'Central Time (US & Canada)'
3318

3419
# The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
3520
# config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
3621
# config.i18n.default_locale = :de
37-
38-
# Configure the default encoding used in templates for Ruby 1.9.
39-
config.encoding = "utf-8"
40-
41-
# Configure sensitive parameters which will be filtered from the log file.
42-
config.filter_parameters += [:password]
43-
44-
# Enable escaping HTML in JSON.
45-
config.active_support.escape_html_entities_in_json = true
46-
47-
# Use SQL instead of Active Record's schema dumper when creating the database.
48-
# This is necessary if your schema can't be completely dumped by the schema dumper,
49-
# like if you have constraints or database-specific column types
50-
# config.active_record.schema_format = :sql
51-
52-
# Enforce whitelist mode for mass assignment.
53-
# This will create an empty whitelist of attributes available for mass-assignment for all models
54-
# in your app. As such, your models will need to explicitly whitelist or blacklist accessible
55-
# parameters by using an attr_accessible or attr_protected declaration.
56-
config.active_record.whitelist_attributes = true
57-
58-
# Enable the asset pipeline
59-
config.assets.enabled = true
60-
61-
# Version of your assets, change this if you want to expire all your assets
62-
config.assets.version = '1.0'
6322
end
6423
end
65-

spec/dummy/config/boot.rb

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
1-
require 'rubygems'
2-
gemfile = File.expand_path('../../../../Gemfile', __FILE__)
1+
# Set up gems listed in the Gemfile.
2+
ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
33

4-
if File.exist?(gemfile)
5-
ENV['BUNDLE_GEMFILE'] = gemfile
6-
require 'bundler'
7-
Bundler.setup
8-
end
9-
10-
$:.unshift File.expand_path('../../../../lib', __FILE__)
4+
require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])

spec/dummy/config/environment.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# Load the rails application
1+
# Load the Rails application.
22
require File.expand_path('../application', __FILE__)
33

4-
# Initialize the rails application
4+
# Initialize the Rails application.
55
Dummy::Application.initialize!
Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,32 @@
11
Dummy::Application.configure do
2-
# Settings specified here will take precedence over those in config/application.rb
2+
# Settings specified here will take precedence over those in config/application.rb.
33

44
# In the development environment your application's code is reloaded on
55
# every request. This slows down response time but is perfect for development
66
# since you don't have to restart the web server when you make code changes.
77
config.cache_classes = false
88

9-
# Log error messages when you accidentally call methods on nil.
10-
config.whiny_nils = true
9+
# Do not eager load code on boot.
10+
config.eager_load = false
1111

12-
# Show full error reports and disable caching
12+
# Show full error reports and disable caching.
1313
config.consider_all_requests_local = true
1414
config.action_controller.perform_caching = false
1515

16-
# Don't care if the mailer can't send
16+
# Don't care if the mailer can't send.
1717
config.action_mailer.raise_delivery_errors = false
1818

19-
# Print deprecation notices to the Rails logger
19+
# Print deprecation notices to the Rails logger.
2020
config.active_support.deprecation = :log
2121

22-
# Only use best-standards-support built into browsers
23-
config.action_dispatch.best_standards_support = :builtin
22+
# Raise an error on page load if there are pending migrations
23+
config.active_record.migration_error = :page_load
2424

25-
# Raise exception on mass assignment protection for Active Record models
26-
config.active_record.mass_assignment_sanitizer = :strict
27-
28-
# Log the query plan for queries taking more than this (works
29-
# with SQLite, MySQL, and PostgreSQL)
30-
config.active_record.auto_explain_threshold_in_seconds = 0.5
31-
32-
# Do not compress assets
33-
config.assets.compress = false
34-
35-
# Expands the lines which load the assets
25+
# Debug mode disables concatenation and preprocessing of assets.
26+
# This option may cause significant delays in view rendering with a large
27+
# number of complex assets.
3628
config.assets.debug = true
29+
30+
# Raises error for missing translations
31+
# config.action_view.raise_on_missing_translations = true
3732
end
Lines changed: 40 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,67 +1,80 @@
11
Dummy::Application.configure do
2-
# Settings specified here will take precedence over those in config/application.rb
2+
# Settings specified here will take precedence over those in config/application.rb.
33

4-
# Code is not reloaded between requests
4+
# Code is not reloaded between requests.
55
config.cache_classes = true
66

7-
# Full error reports are disabled and caching is turned on
7+
# Eager load code on boot. This eager loads most of Rails and
8+
# your application in memory, allowing both thread web servers
9+
# and those relying on copy on write to perform better.
10+
# Rake tasks automatically ignore this option for performance.
11+
config.eager_load = true
12+
13+
# Full error reports are disabled and caching is turned on.
814
config.consider_all_requests_local = false
915
config.action_controller.perform_caching = true
1016

11-
# Disable Rails's static asset server (Apache or nginx will already do this)
17+
# Enable Rack::Cache to put a simple HTTP cache in front of your application
18+
# Add `rack-cache` to your Gemfile before enabling this.
19+
# For large-scale production use, consider using a caching reverse proxy like nginx, varnish or squid.
20+
# config.action_dispatch.rack_cache = true
21+
22+
# Disable Rails's static asset server (Apache or nginx will already do this).
1223
config.serve_static_assets = false
1324

14-
# Compress JavaScripts and CSS
15-
config.assets.compress = true
25+
# Compress JavaScripts and CSS.
26+
config.assets.js_compressor = :uglifier
27+
# config.assets.css_compressor = :sass
1628

17-
# Don't fallback to assets pipeline if a precompiled asset is missed
29+
# Do not fallback to assets pipeline if a precompiled asset is missed.
1830
config.assets.compile = false
1931

20-
# Generate digests for assets URLs
32+
# Generate digests for assets URLs.
2133
config.assets.digest = true
2234

23-
# Defaults to nil and saved in location specified by config.assets.prefix
24-
# config.assets.manifest = YOUR_PATH
35+
# Version of your assets, change this if you want to expire all your assets.
36+
config.assets.version = '1.0'
2537

26-
# Specifies the header that your server uses for sending files
38+
# Specifies the header that your server uses for sending files.
2739
# config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
2840
# config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
2941

3042
# Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
3143
# config.force_ssl = true
3244

33-
# See everything in the log (default is :info)
34-
# config.log_level = :debug
45+
# Set to :debug to see everything in the log.
46+
config.log_level = :info
3547

36-
# Prepend all log lines with the following tags
48+
# Prepend all log lines with the following tags.
3749
# config.log_tags = [ :subdomain, :uuid ]
3850

39-
# Use a different logger for distributed setups
51+
# Use a different logger for distributed setups.
4052
# config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
4153

42-
# Use a different cache store in production
54+
# Use a different cache store in production.
4355
# config.cache_store = :mem_cache_store
4456

45-
# Enable serving of images, stylesheets, and JavaScripts from an asset server
57+
# Enable serving of images, stylesheets, and JavaScripts from an asset server.
4658
# config.action_controller.asset_host = "http://assets.example.com"
4759

48-
# Precompile additional assets (application.js, application.css, and all non-JS/CSS are already added)
60+
# Precompile additional assets.
61+
# application.js, application.css, and all non-JS/CSS in app/assets folder are already added.
4962
# config.assets.precompile += %w( search.js )
5063

51-
# Disable delivery errors, bad email addresses will be ignored
64+
# Ignore bad email addresses and do not raise email delivery errors.
65+
# Set this to true and configure the email server for immediate delivery to raise delivery errors.
5266
# config.action_mailer.raise_delivery_errors = false
5367

54-
# Enable threaded mode
55-
# config.threadsafe!
56-
5768
# Enable locale fallbacks for I18n (makes lookups for any locale fall back to
58-
# the I18n.default_locale when a translation can not be found)
69+
# the I18n.default_locale when a translation can not be found).
5970
config.i18n.fallbacks = true
6071

61-
# Send deprecation notices to registered listeners
72+
# Send deprecation notices to registered listeners.
6273
config.active_support.deprecation = :notify
6374

64-
# Log the query plan for queries taking more than this (works
65-
# with SQLite, MySQL, and PostgreSQL)
66-
# config.active_record.auto_explain_threshold_in_seconds = 0.5
75+
# Disable automatic flushing of the log to improve performance.
76+
# config.autoflush_log = false
77+
78+
# Use default logging formatter so that PID and timestamp are not suppressed.
79+
config.log_formatter = ::Logger::Formatter.new
6780
end

0 commit comments

Comments
 (0)