No reason to save output to a log file it there's no output :/

Author: byt3bl33d3r

modules/credentials/mimikatz.py

@@ -212,7 +212,7 @@ def on_response(self, context, response):
                     context.db.add_credential(credtype, domain, username, password)
                     context.log.highlight('{}\\{}:{}'.format(domain, username, password))
 
-        log_name = 'Mimikatz-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
-        with open('logs/' + log_name, 'w') as mimikatz_output:
-            mimikatz_output.write(data)
-        context.log.info("Saved Mimikatz's output to {}".format(log_name))
+            log_name = 'Mimikatz-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
+            with open('logs/' + log_name, 'w') as mimikatz_output:
+                mimikatz_output.write(data)
+            context.log.info("Saved Mimikatz's output to {}".format(log_name))

modules/situational_awareness/get_computers.py

@@ -88,15 +88,15 @@ def on_response(self, context, response):
         #We've received the response, stop tracking this host
         response.stop_tracking_host()
 
-        if len(data) > 0:
+        if len(data):
             def print_post_data(data):
                 buf = StringIO(data.strip()).readlines()
                 for line in buf:
                     context.log.highlight(line.strip())
 
             print_post_data(data)
 
-        log_name = 'Computers-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
-        with open('logs/' + log_name, 'w') as log_file:
-            log_file.write(data)
-        context.log.info("Saved output to {}".format(log_name))
+            log_name = 'Computers-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
+            with open('logs/' + log_name, 'w') as log_file:
+                log_file.write(data)
+            context.log.info("Saved output to {}".format(log_name))

modules/situational_awareness/get_group_members.py

@@ -80,15 +80,15 @@ def on_response(self, context, response):
         #We've received the response, stop tracking this host
         response.stop_tracking_host()
 
-        if len(data) > 0:
+        if len(data):
             def print_post_data(data):
                 buf = StringIO(data.strip()).readlines()
                 for line in buf:
                     context.log.highlight(line.strip())
 
             print_post_data(data)
 
-        log_name = 'GroupMembers-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
-        with open('logs/' + log_name, 'w') as log_file:
-            log_file.write(data)
-        context.log.info("Saved output to {}".format(log_name))
+            log_name = 'GroupMembers-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
+            with open('logs/' + log_name, 'w') as log_file:
+                log_file.write(data)
+            context.log.info("Saved output to {}".format(log_name))

modules/situational_awareness/get_groups.py

@@ -80,15 +80,15 @@ def on_response(self, context, response):
         #We've received the response, stop tracking this host
         response.stop_tracking_host()
 
-        if len(data) > 0:
+        if len(data):
             def print_post_data(data):
                 buf = StringIO(data.strip()).readlines()
                 for line in buf:
                     context.log.highlight(line.strip())
 
             print_post_data(data)
 
-        log_name = 'Groups-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
-        with open('logs/' + log_name, 'w') as log_file:
-            log_file.write(data)
-        context.log.info("Saved output to {}".format(log_name))
+            log_name = 'Groups-{}-{}.log'.format(response.client_address[0], datetime.now().strftime("%Y-%m-%d_%H%M%S"))
+            with open('logs/' + log_name, 'w') as log_file:
+                log_file.write(data)
+            context.log.info("Saved output to {}".format(log_name))