Skip to content

Commit d526c43

Browse files
authored
feat(postgresql): add columnref in target_el directly (#23)
In Bytebase query span, we need to handling star expansion like SELECT table.* FROM table. Considering returning SourceColumnSet for other candidates in a_expr make code cleaner.
1 parent 8f3aec1 commit d526c43

File tree

6 files changed

+1994
-1909
lines changed

6 files changed

+1994
-1909
lines changed

postgresql/PostgreSQLParser.g4

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4030,7 +4030,8 @@ target_list
40304030
;
40314031

40324032
target_el
4033-
: a_expr target_alias? # target_label
4033+
: columnref # target_columnref // NOTE(parser): Add by Bytebase to handling table.* easily.
4034+
| a_expr target_alias? # target_label
40344035
| STAR # target_star
40354036
;
40364037

postgresql/postgresql_parser.go

Lines changed: 1973 additions & 1908 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

postgresql/postgresqlparser_base_listener.go

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

postgresql/postgresqlparser_base_visitor.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

postgresql/postgresqlparser_listener.go

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

postgresql/postgresqlparser_visitor.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)