Skip to content

Commit 2281acc

Browse files
committed
fix: test
1 parent 5e636f5 commit 2281acc

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

provider/internal/mock_client.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ func (c *mockClient) CreateInstance(_ context.Context, instanceID string, instan
206206
ExternalLink: instance.ExternalLink,
207207
DataSources: instance.DataSources,
208208
Environment: instance.Environment,
209+
Options: &v1pb.InstanceOptions{},
209210
}
210211

211212
envID, err := GetEnvironmentID(ins.Environment)
@@ -242,6 +243,12 @@ func (c *mockClient) UpdateInstance(ctx context.Context, patch *v1pb.Instance, u
242243
if slices.Contains(updateMasks, "data_sources") {
243244
ins.DataSources = patch.DataSources
244245
}
246+
if slices.Contains(updateMasks, "options.sync_interval") {
247+
ins.Options.SyncInterval = patch.Options.SyncInterval
248+
}
249+
if slices.Contains(updateMasks, "options.maximum_connections") {
250+
ins.Options.MaximumConnections = patch.Options.MaximumConnections
251+
}
245252

246253
c.instanceMap[ins.Name] = ins
247254
return ins, nil
@@ -788,7 +795,7 @@ func (c *mockClient) UpdateGroup(ctx context.Context, group *v1pb.Group, updateM
788795
}
789796

790797
// DeleteGroup deletes the group by name.
791-
func (c *mockClient) DeleteGroup(ctx context.Context, name string) error {
798+
func (c *mockClient) DeleteGroup(_ context.Context, name string) error {
792799
delete(c.groupMap, name)
793800
return nil
794801
}

provider/resource_instance.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -253,11 +253,13 @@ func resourceInstanceCreate(ctx context.Context, d *schema.ResourceData, m inter
253253
if externalLink != "" && externalLink != existedInstance.ExternalLink {
254254
updateMasks = append(updateMasks, "external_link")
255255
}
256-
if instanceOptions.MaximumConnections != existedInstance.Options.MaximumConnections {
257-
updateMasks = append(updateMasks, "options.maximum_connections")
258-
}
259-
if instanceOptions.SyncInterval.GetSeconds() != existedInstance.Options.SyncInterval.GetSeconds() {
260-
updateMasks = append(updateMasks, "options.sync_interval")
256+
if op := existedInstance.Options; op != nil {
257+
if instanceOptions.SyncInterval.GetSeconds() != op.SyncInterval.GetSeconds() {
258+
updateMasks = append(updateMasks, "options.sync_interval")
259+
}
260+
if instanceOptions.MaximumConnections != op.MaximumConnections {
261+
updateMasks = append(updateMasks, "options.maximum_connections")
262+
}
261263
}
262264
if len(dataSourceList) > 0 {
263265
updateMasks = append(updateMasks, "data_sources")

0 commit comments

Comments
 (0)