feat: add approval template id field for Bytebase 3.11 compatibility #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the new ApprovalTemplate.id field introduced in Bytebase API to support both built-in and custom approval templates. Changes: - Add required 'id' field to approval flow schema with validation - Update convertToV1ApprovalSetting to set template ID - Update flattenWorkspaceApprovalSetting to include template ID - Update Bytebase protobuf dependencies to latest version Built-in templates use 'bb.*' prefix (e.g., 'bb.project-owner', 'bb.workspace-dba'), while custom templates use UUIDs. Related: bytebase/bytebase#17689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update all approval flow test cases to include the new required 'id' field. Use custom flow IDs (e.g., 'test-flow', 'test-ddl-approval-flow') instead of built-in 'bb.*' prefixed IDs for test cases. Fixes test failures caused by adding the required id field to ApprovalTemplate. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update all examples and tutorials to include the required 'id' field in approval flow configurations. Regenerate documentation to reflect the new schema changes. Changes: - Add id field to examples/setup/approval_flow.tf - Add id field to tutorials/4-3-approval-flow.tf - Regenerate docs/resources/setting.md with updated schema - Regenerate docs/data-sources/setting.md with updated schema All examples now use the built-in template ID format: 'bb.project-owner-workspace-dba-workspace-admin' 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
d-bytebase
changed the title
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ecmadao
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the new
ApprovalTemplate.idfield introduced in Bytebase API to support both built-in and custom approval templates.Changes
idfield to approval flow schema with validationconvertToV1ApprovalSettingto set template ID when creating/updatingflattenWorkspaceApprovalSettingto include template ID when readingbuf.build/gen/go/bytebase/bytebase/protocolbuffers/go→v1.36.10-20251010220308-691f96ff880a.1buf.build/gen/go/bytebase/bytebase/connectrpc/go→v1.19.1-20251010220308-691f96ff880a.1Template ID Format
bb.*prefix (e.g.,bb.project-owner,bb.workspace-dba)Example Usage
Related
Test Plan
🤖 Generated with Claude Code