682 SF, spotbugs

Author: ivicac

server/libs/atlas/atlas-coordinator/atlas-coordinator-api/src/main/java/com/bytechef/atlas/coordinator/task/dispatcher/TaskDispatcherResolver.java

@@ -19,6 +19,7 @@
 package com.bytechef.atlas.coordinator.task.dispatcher;
 
 import com.bytechef.atlas.configuration.domain.Task;
+import org.springframework.lang.Nullable;
 
 /**
  * The strategy interface used for resolving the apprpriate {@link TaskDispatcher} instance for a given {@link Task}.
@@ -35,5 +36,6 @@ public interface TaskDispatcherResolver {
      * @return a {@link TaskDispatcher} instance to execute the given task or <code>null</code> if unable to resolve
      *         one.
      */
+    @Nullable
     TaskDispatcher<? extends Task> resolve(Task task);
 }

server/libs/atlas/atlas-coordinator/atlas-coordinator-impl/src/main/java/com/bytechef/atlas/coordinator/TaskCoordinator.java

@@ -71,9 +71,9 @@ public class TaskCoordinator {
     @SuppressFBWarnings("EI")
     public TaskCoordinator(
         List<ApplicationEventListener> applicationEventListeners, List<ErrorEventListener> errorEventListeners,
-        ApplicationEventPublisher eventPublisher,
-        JobExecutor jobExecutor, JobService jobService, TaskCompletionHandler taskCompletionHandler,
-        TaskDispatcher<? super Task> taskDispatcher, TaskExecutionService taskExecutionService) {
+        ApplicationEventPublisher eventPublisher, JobExecutor jobExecutor, JobService jobService,
+        TaskCompletionHandler taskCompletionHandler, TaskDispatcher<? super Task> taskDispatcher,
+        TaskExecutionService taskExecutionService) {
 
         this.applicationEventListeners = applicationEventListeners;
         this.errorEventListeners = errorEventListeners;

server/libs/atlas/atlas-worker/atlas-worker-config/src/main/java/com/bytechef/atlas/worker/config/TaskWorkerMessageBrokerConfigurerConfiguration.java

@@ -58,8 +58,8 @@ MessageBrokerConfigurer<?> taskWorkerMessageBrokerConfigurer(
                 .getSubscriptions();
 
             subscriptions.forEach((routeName, concurrency) -> messageBrokerListenerRegistrar.registerListenerEndpoint(
-                listenerEndpointRegistrar, TaskWorkerMessageRoute.ofTaskMessageRoute(routeName),
-                concurrency, taskWorkerDelegate, "onTaskExecutionEvent"));
+                listenerEndpointRegistrar, TaskWorkerMessageRoute.ofTaskMessageRoute(routeName), concurrency,
+                taskWorkerDelegate, "onTaskExecutionEvent"));
 
             messageBrokerListenerRegistrar.registerListenerEndpoint(
                 listenerEndpointRegistrar, TaskWorkerMessageRoute.CONTROL_EVENTS, 1, taskWorkerDelegate,

server/libs/automation/automation-configuration/automation-configuration-rest/automation-configuration-rest-impl/src/test/java/com/bytechef/automation/configuration/web/rest/config/AutomationConfigurationRestTestConfiguration.java

@@ -16,14 +16,7 @@
 
 package com.bytechef.automation.configuration.web.rest.config;
 
-import static org.mockito.Mockito.mock;
-
-import com.bytechef.atlas.configuration.service.WorkflowService;
 import com.bytechef.jackson.config.JacksonConfiguration;
-import com.bytechef.platform.component.service.ComponentDefinitionService;
-import com.bytechef.platform.configuration.facade.ComponentConnectionFacade;
-import com.bytechef.platform.configuration.facade.WorkflowFacade;
-import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Import;
@@ -42,24 +35,4 @@
 @Configuration
 @Import(JacksonConfiguration.class)
 public class AutomationConfigurationRestTestConfiguration {
-
-    @Bean
-    ComponentConnectionFacade componentConnectionFacade() {
-        return mock(ComponentConnectionFacade.class);
-    }
-
-    @Bean
-    ComponentDefinitionService componentDefinitionService() {
-        return mock(ComponentDefinitionService.class);
-    }
-
-    @Bean
-    WorkflowService workflowService() {
-        return mock(WorkflowService.class);
-    }
-
-    @Bean
-    WorkflowFacade workflowFacade() {
-        return mock(WorkflowFacade.class);
-    }
 }

server/libs/platform/platform-coordinator/build.gradle.kts

@@ -8,6 +8,7 @@ dependencies {
     implementation("org.springframework.boot:spring-boot-autoconfigure")
     implementation("org.springframework.retry:spring-retry")
     implementation("org.springframework:spring-web")
+    implementation("com.github.ben-manes.caffeine:caffeine")
     implementation(project(":server:libs:atlas:atlas-coordinator:atlas-coordinator-api"))
     implementation(project(":server:libs:atlas:atlas-coordinator:atlas-coordinator-impl"))
     implementation(project(":server:libs:atlas:atlas-execution:atlas-execution-service"))

server/libs/platform/platform-webhook/platform-webhook-impl/src/main/java/com/bytechef/platform/webhook/executor/WebhookWorkflowExecutorImpl.java

@@ -31,6 +31,7 @@
 import com.bytechef.platform.workflow.coordinator.event.TriggerWebhookEvent;
 import com.bytechef.platform.workflow.coordinator.event.TriggerWebhookEvent.WebhookParameters;
 import com.bytechef.platform.workflow.execution.facade.PrincipalJobFacade;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
@@ -50,6 +51,7 @@ public class WebhookWorkflowExecutorImpl implements WebhookWorkflowExecutor {
     private final WebhookWorkflowSyncExecutor webhookWorkflowSyncExecutor;
     private final TaskFileStorage taskFileStorage;
 
+    @SuppressFBWarnings("EI")
     public WebhookWorkflowExecutorImpl(
         ApplicationEventPublisher eventPublisher, JobPrincipalAccessorRegistry jobPrincipalAccessorRegistry,
         PrincipalJobFacade principalJobFacade, JobSyncExecutor jobSyncExecutor,

server/libs/platform/platform-workflow/platform-workflow-test/platform-workflow-test-rest/build.gradle.kts

@@ -62,9 +62,11 @@ dependencies {
     implementation("org.slf4j:slf4j-api")
     implementation("org.springframework:spring-web")
     implementation("org.springframework.boot:spring-boot-autoconfigure")
+    implementation("com.github.ben-manes.caffeine:caffeine")
     implementation(project(":server:libs:atlas:atlas-coordinator:atlas-coordinator-api"))
     implementation(project(":server:libs:core:commons:commons-util"))
     implementation(project(":server:libs:core:rest:rest-api"))
+    implementation(project(":server:libs:core:tenant:tenant-api"))
     implementation(project(":server:libs:platform:platform-file-storage:platform-file-storage-api"))
     implementation(project(":server:libs:platform:platform-workflow:platform-workflow-execution:platform-workflow-execution-rest:platform-workflow-execution-rest-api"))
     implementation(project(":server:libs:platform:platform-workflow:platform-workflow-test:platform-workflow-test-api"))