682 Fix potential race condition where the future is cancelled before 'awaitTestResult' completes, which could leave resources in an inconsistent state

Author: ivicac

server/libs/platform/platform-workflow/platform-workflow-test/platform-workflow-test-rest/src/main/java/com/bytechef/platform/workflow/test/web/rest/WorkflowTestApiController.java

@@ -38,6 +38,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.concurrent.CancellationException;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Matcher;
@@ -159,7 +160,9 @@ public SseEmitter attachWorkflowTest(@PathVariable Long jobId) {
 
         future.whenComplete((result, throwable) -> {
             try {
-                if (throwable != null) {
+                if (throwable instanceof CancellationException) {
+                    sendToEmitter(key, createEvent("error", "Aborted"));
+                } else if (throwable != null) {
                     sendToEmitter(
                         key, createEvent("error", Objects.toString(throwable.getMessage(), "An error occurred")));
                 } else {
@@ -186,23 +189,21 @@ public SseEmitter attachWorkflowTest(@PathVariable Long jobId) {
     public ResponseEntity<Void> stopWorkflowTest(@PathVariable String jobId) {
         final String key = TenantCacheKeyUtils.getKey(jobId);
 
-        workflowTestFacade.stopTest(Long.parseLong(jobId));
-
         CompletableFuture<WorkflowTestExecutionModel> future = runs.getIfPresent(key);
-        if (future != null) {
-            runs.invalidate(key);
-        }
-
-        try {
-            sendToEmitter(key, createEvent("error", "Aborted"));
-        } finally {
-            pendingEvents.invalidate(key);
-            completeAndClearEmitter(key);
-            unregisterListeners(key);
-        }
 
         if (future != null && !future.isDone()) {
             future.cancel(true);
+        } else {
+            workflowTestFacade.stopTest(Long.parseLong(jobId));
+
+            try {
+                sendToEmitter(key, createEvent("error", "Aborted"));
+            } finally {
+                runs.invalidate(key);
+                pendingEvents.invalidate(key);
+                completeAndClearEmitter(key);
+                unregisterListeners(key);
+            }
         }
 
         return ResponseEntity.ok()
@@ -261,7 +262,11 @@ public SseEmitter testWorkflow(
 
         future.whenComplete((result, throwable) -> {
             try {
-                if (throwable != null) {
+                if (throwable instanceof CancellationException) {
+                    workflowTestFacade.stopTest(jobId);
+
+                    sendToEmitter(key, createEvent("error", "Aborted"));
+                } else if (throwable != null) {
                     sendToEmitter(
                         key, createEvent("error", Objects.toString(throwable.getMessage(), "An error occurred")));
                 } else {

server/libs/platform/platform-workflow/platform-workflow-test/platform-workflow-test-rest/src/test/java/com/bytechef/platform/workflow/test/web/rest/WorkflowTestApiControllerTest.java

@@ -48,7 +48,6 @@
 import java.util.Set;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentMap;
-import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicReference;