3955 DataTables - client - Update tests

Author: ivicac

client/src/pages/automation/datatable/components/tests/DataTableActionsMenu.test.tsx

@@ -105,7 +105,7 @@ describe('DataTableActionsMenu', () => {
             expect(onExportCsv).toHaveBeenCalledTimes(1);
         });
 
-        it('should call onRenameTable when Rename table is clicked', async () => {
+        it('should call onRenameTable when Rename Table is clicked', async () => {
             const user = userEvent.setup();
             const onRenameTable = vi.fn();
 

client/src/pages/automation/datatable/components/tests/DataTableLeftSidebar.test.tsx

@@ -1,4 +1,4 @@
-import {useDeleteDataTableDialogStore} from '@/pages/automation/datatable/stores/useDeleteDataTableDialogStore';
+import {useDeleteDataTableAlertDialogStore} from '@/pages/automation/datatable/stores/useDeleteDataTableAlertDialogStore';
 import {useRenameDataTableDialogStore} from '@/pages/automation/datatable/stores/useRenameDataTableDialogStore';
 import {render, resetAll, screen, userEvent, windowResizeObserver} from '@/shared/util/test-utils';
 import {QueryClient, QueryClientProvider} from '@tanstack/react-query';
@@ -114,7 +114,7 @@ afterEach(() => {
     queryClient.clear();
 
     // Reset zustand stores
-    useDeleteDataTableDialogStore.getState().clearTableToDelete();
+    useDeleteDataTableAlertDialogStore.getState().clearTableToDelete();
     useRenameDataTableDialogStore.getState().clearTableToRename();
 });
 
@@ -236,7 +236,7 @@ describe('DataTableLeftSidebar', () => {
 
             await user.click(deleteOption);
 
-            expect(screen.getByText('Delete Table')).toBeInTheDocument();
+            expect(screen.getByText('Are you absolutely sure?')).toBeInTheDocument();
         });
 
         it('should close delete dialog when cancel is clicked', async () => {

client/src/pages/automation/datatable/components/tests/DataTableLeftSidebarDropdownMenu.test.tsx

@@ -10,7 +10,7 @@ const hoisted = vi.hoisted(() => {
     };
 });
 
-vi.mock('../../hooks/useDeleteDataTableDialog', () => ({
+vi.mock('../../hooks/useDeleteDataTableAlertDialog', () => ({
     default: () => ({
         handleOpen: hoisted.mockHandleDeleteOpen,
     }),

client/src/pages/automation/datatable/components/tests/DeleteDataTableAlertDialog.test.tsx

@@ -0,0 +1,83 @@
+import {render, resetAll, screen, userEvent, windowResizeObserver} from '@/shared/util/test-utils';
+import {afterEach, beforeEach, describe, expect, it, vi} from 'vitest';
+
+import DeleteDataTableAlertDialog from '../DeleteDataTableAlertDialog';
+
+const hoisted = vi.hoisted(() => {
+    return {
+        mockHandleClose: vi.fn(),
+        mockHandleDelete: vi.fn(),
+        storeState: {
+            open: true,
+        },
+    };
+});
+
+vi.mock('../../hooks/useDeleteDataTableAlertDialog', () => ({
+    default: () => ({
+        handleClose: hoisted.mockHandleClose,
+        handleDelete: hoisted.mockHandleDelete,
+        open: hoisted.storeState.open,
+    }),
+}));
+
+beforeEach(() => {
+    windowResizeObserver();
+    hoisted.storeState.open = true;
+});
+
+afterEach(() => {
+    resetAll();
+    vi.clearAllMocks();
+});
+
+describe('DeleteDataTableAlertDialog', () => {
+    describe('rendering', () => {
+        it('should render the dialog when open', () => {
+            render(<DeleteDataTableAlertDialog />);
+
+            expect(screen.getByText('Are you absolutely sure?')).toBeInTheDocument();
+        });
+
+        it('should render cancel and delete buttons', () => {
+            render(<DeleteDataTableAlertDialog />);
+
+            expect(screen.getByRole('button', {name: 'Cancel'})).toBeInTheDocument();
+            expect(screen.getByRole('button', {name: 'Delete'})).toBeInTheDocument();
+        });
+
+        it('should not render when not open', () => {
+            hoisted.storeState.open = false;
+
+            render(<DeleteDataTableAlertDialog />);
+
+            expect(screen.queryByText('Are you absolutely sure?')).not.toBeInTheDocument();
+        });
+    });
+
+    describe('interactions', () => {
+        it('should call handleDelete when delete button is clicked', async () => {
+            const user = userEvent.setup();
+
+            render(<DeleteDataTableAlertDialog />);
+
+            const deleteButton = screen.getByRole('button', {name: 'Delete'});
+
+            await user.click(deleteButton);
+
+            expect(hoisted.mockHandleDelete).toHaveBeenCalledTimes(1);
+        });
+
+        it('should call handleClose when cancel is clicked', async () => {
+            const user = userEvent.setup();
+
+            render(<DeleteDataTableAlertDialog />);
+
+            const cancelButton = screen.getByRole('button', {name: 'Cancel'});
+
+            await user.click(cancelButton);
+
+            expect(hoisted.mockHandleClose).toHaveBeenCalledTimes(1);
+        });
+    });
+});

client/src/pages/automation/datatable/components/tests/DeleteDataTableDialog.test.tsx

@@ -8,7 +8,7 @@ const hoisted = vi.hoisted(() => {
         mockCanRename: true,
         mockCurrentName: 'originalColumn',
         mockHandleOpenChange: vi.fn(),
-        mockHandleRename: vi.fn(),
+        mockHandleRenameSubmit: vi.fn(),
         mockHandleRenameValueChange: vi.fn(),
         mockOpen: true,
         mockRenameValue: 'originalColumn',
@@ -20,7 +20,7 @@ vi.mock('../../hooks/useRenameDataTableColumnDialog', () => ({
         canRename: hoisted.mockCanRename,
         currentName: hoisted.mockCurrentName,
         handleOpenChange: hoisted.mockHandleOpenChange,
-        handleRename: hoisted.mockHandleRename,
+        handleRenameSubmit: hoisted.mockHandleRenameSubmit,
         handleRenameValueChange: hoisted.mockHandleRenameValueChange,
         open: hoisted.mockOpen,
         renameValue: hoisted.mockRenameValue,
@@ -62,6 +62,12 @@ describe('RenameDataTableColumnDialog', () => {
             expect(screen.getByText('Rename Column')).toBeInTheDocument();
         });
 
+        it('should display the dialog description', () => {
+            render(<RenameDataTableColumnDialog />);
+
+            expect(screen.getByText('Enter a new name for this column.')).toBeInTheDocument();
+        });
+
         it('should render the current column name in label', () => {
             hoisted.mockCurrentName = 'myColumn';
 
@@ -154,7 +160,7 @@ describe('RenameDataTableColumnDialog', () => {
 
             await user.click(renameButton);
 
-            expect(hoisted.mockHandleRename).toHaveBeenCalled();
+            expect(hoisted.mockHandleRenameSubmit).toHaveBeenCalled();
         });
 
         it('should not call handleRename when Rename button is disabled', async () => {
@@ -168,7 +174,7 @@ describe('RenameDataTableColumnDialog', () => {
 
             await user.click(renameButton);
 
-            expect(hoisted.mockHandleRename).not.toHaveBeenCalled();
+            expect(hoisted.mockHandleRenameSubmit).not.toHaveBeenCalled();
         });
     });
 });

client/src/pages/automation/datatable/components/tests/RenameDataTableColumnDialog.test.tsx

@@ -6,7 +6,7 @@ import RenameDataTableDialog from '../RenameDataTableDialog';
 const hoisted = vi.hoisted(() => {
     return {
         mockHandleOpenChange: vi.fn(),
-        mockHandleRename: vi.fn(),
+        mockHandleRenameSubmit: vi.fn(),
         mockHandleRenameValueChange: vi.fn(),
         storeState: {
             canRename: true,
@@ -20,7 +20,7 @@ vi.mock('../../hooks/useRenameDataTableDialog', () => ({
     default: () => ({
         canRename: hoisted.storeState.canRename,
         handleOpenChange: hoisted.mockHandleOpenChange,
-        handleRename: hoisted.mockHandleRename,
+        handleRenameSubmit: hoisted.mockHandleRenameSubmit,
         handleRenameValueChange: hoisted.mockHandleRenameValueChange,
         open: hoisted.storeState.open,
         renameValue: hoisted.storeState.renameValue,
@@ -94,7 +94,7 @@ describe('RenameDataTableDialog', () => {
 
             await user.click(renameButton);
 
-            expect(hoisted.mockHandleRename).toHaveBeenCalledTimes(1);
+            expect(hoisted.mockHandleRenameSubmit).toHaveBeenCalledTimes(1);
         });
 
         it('should call handleOpenChange when cancel is clicked', async () => {

client/src/pages/automation/datatable/components/tests/RenameDataTableDialog.test.tsx

@@ -46,7 +46,7 @@ vi.mock('../../stores/useCurrentDataTableStore', () => ({
     }),
 }));
 
-vi.mock('../useDeleteDataTableDialog', () => ({
+vi.mock('../useDeleteDataTableAlertDialog', () => ({
     default: () => ({
         handleDelete: vi.fn(),
         handleOpen: hoisted.mockOpenDeleteDialog,