Skip to content

Commit bc92af2

Browse files
fix(ci): more consistent artifact upload/download
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
1 parent aabd460 commit bc92af2

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

.github/workflows/main.yml

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ jobs:
130130
- name: Build ComponentizeJS
131131
if: steps.starlingmonkey-jit.outputs.cache-hit != 'true'
132132
run: |
133+
npm run clean
133134
npm run build
134135
135136
- uses: actions/upload-artifact@v4
@@ -199,6 +200,7 @@ jobs:
199200
- name: Build Weval
200201
if: steps.starlingmonkey-aot.outputs.cache-hit != 'true'
201202
run: |
203+
npm run clean
202204
npm run build:weval
203205
204206
- uses: actions/upload-artifact@v4
@@ -244,19 +246,22 @@ jobs:
244246
lib/spidermonkey-embedding-splicer.js
245247
target
246248
247-
- name: Restore StarlingMonkey from cache
249+
- name: Restore StarlingMonkey build from cache
248250
uses: actions/cache/restore@v4
249-
id: starlingmonkey-jit
251+
id: restore-starlingmonkey-jit-build
250252
with:
251253
key: output-starlingmonkey-jit-node-${{matrix.node-version}}-${{ steps.starlingmonkey-commit.outputs.STARLINGMONKEY_HASH }}
252254
path: |
253255
lib/starlingmonkey_embedding.wasm
254-
target
256+
build-release
255257
256258
- uses: actions/download-artifact@v4
257-
if: steps.starlingmonkey-jit.outputs.cache-hit != 'true'
259+
if: steps.restore-starlingmonkey-jit-build.outputs.cache-hit != 'true'
258260
with:
259261
name: starlingmonkey-jit-node-${{matrix.node-version}}-${{ steps.starlingmonkey-commit.outputs.STARLINGMONKEY_HASH }}
262+
path: |
263+
lib/starlingmonkey_embedding.wasm
264+
build-release
260265
261266
- uses: actions/setup-node@v4
262267
with:
@@ -308,20 +313,24 @@ jobs:
308313
lib/spidermonkey-embedding-splicer.js
309314
target
310315
311-
- name: Restore StarlingMonkey (Weval) from cache
316+
- name: Restore StarlingMonkey AOT build from cache
312317
uses: actions/cache/restore@v4
313-
id: starlingmonkey-aot
318+
id: restore-starlingmonkey-aot-build
314319
with:
315320
key: output-starlingmonkey-aot-node-${{matrix.node-version}}-${{ steps.starlingmonkey-commit.outputs.STARLINGMONKEY_HASH }}
316321
path: |
317322
lib/starlingmonkey_embedding_weval.wasm
318323
lib/starlingmonkey_ics.wevalcache
319-
target
324+
build-release-weval
320325
321326
- uses: actions/download-artifact@v4
322-
if: steps.starlingmonkey-aot.outputs.cache-hit != 'true'
327+
if: steps.restore-starlingmonkey-aot-build.outputs.cache-hit != 'true'
323328
with:
324329
name: starlingmonkey-aot-node-${{matrix.node-version}}-${{ steps.starlingmonkey-commit.outputs.STARLINGMONKEY_HASH }}
330+
path: |
331+
lib/starlingmonkey_embedding_weval.wasm
332+
lib/starlingmonkey_ics.wevalcache
333+
build-release-weval
325334
326335
- uses: actions/setup-node@v4
327336
with:

0 commit comments

Comments
 (0)