Fix memory leak in call() retptr allocation (#295)

ludfjig · web-flow · commit efb1b6db247e · 2025-09-16T11:56:17.000+02:00
Signed-off-by: Ludvig Liljenberg &lt;4257730+ludfjig@users.noreply.github.com&gt;
diff --git a/embedding/embedding.cpp b/embedding/embedding.cpp
@@ -232,7 +232,7 @@ __attribute__((export_name("call"))) uint32_t call(uint32_t fn_idx,
   void *retptr = nullptr;
   if (fn->retptr) {
     LOG("(call) setting retptr at arg %d\n", argcnt);
-    retptr = JS_realloc(Runtime.cx, 0, 0, fn->retsize);
+    retptr = cabi_realloc(nullptr, 0, 4, fn->retsize);
     args[argcnt].setInt32((uint32_t)retptr);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ __attribute__((export_name("call"))) uint32_t call(uint32_t fn_idx,`
`232`	`232`	`void *retptr = nullptr;`
`233`	`233`	`if (fn->retptr) {`
`234`	`234`	`LOG("(call) setting retptr at arg %d\n", argcnt);`
`235`		`- retptr = JS_realloc(Runtime.cx, 0, 0, fn->retsize);`
	`235`	`+ retptr = cabi_realloc(nullptr, 0, 4, fn->retsize);`
`236`	`236`	`args[argcnt].setInt32((uint32_t)retptr);`
`237`	`237`	`}`
`238`	`238`