Skip to content

Commit 0cc1181

Browse files
Try fixing release-please permissions (#256)
Let's see if this fixes the release permissions. It at least matches the [release-please action's documentation](https://github.com/googleapis/release-please-action#basic-configuration). In looking at this, I also noticed that the published artifacts aren't quite what I expected—my apologies for not catching this earlier! There's a key difference between the `starling-raw.wasm` and `starling.wasm` builds, and we shouldn't rename the former to the latter for the released artifacts. Instead, I simply added both, so that they can both be made use of directly.
1 parent 868bf2b commit 0cc1181

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

.github/workflows/release-please.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ on:
55
branches:
66
- main
77

8+
permissions:
9+
contents: write
10+
issues: write
11+
pull-requests: write
12+
813
jobs:
914
release-please:
1015
runs-on: ubuntu-latest
11-
permissions:
12-
contents: write
13-
issues: write
14-
pull-requests: write
1516
outputs:
1617
release_created: ${{ steps.release.outputs.release_created }}
1718
tag_name: ${{ steps.release.outputs.tag_name }}
@@ -56,9 +57,17 @@ jobs:
5657
run: |
5758
mkdir -p release-artifacts
5859
59-
cp build-release/starling-raw.wasm release-artifacts/starling.wasm
60-
cp build-weval/starling-raw.wasm release-artifacts/starling-weval.wasm
61-
cp build-debug/starling-raw.wasm release-artifacts/starling-debug.wasm
60+
# Core-module versions of the runtime
61+
cp build-release/starling-raw.wasm release-artifacts/starling-raw.wasm
62+
cp build-weval/starling-raw.wasm release-artifacts/starling-raw-weval.wasm
63+
cp build-debug/starling-raw.wasm release-artifacts/starling-raw-debug.wasm
64+
65+
# Component-versions of the runtime
66+
cp build-release/starling.wasm release-artifacts/starling.wasm
67+
cp build-weval/starling.wasm release-artifacts/starling-weval.wasm
68+
cp build-debug/starling.wasm release-artifacts/starling-debug.wasm
69+
70+
# Supporting artifacts
6271
cp build-release/preview1-adapter.wasm release-artifacts
6372
cp build-weval/starling-ics.wevalcache release-artifacts
6473

0 commit comments

Comments
 (0)