Add clang-tidy and clang-tidy-fix targets

Author: andreiltd

.clang-tidy

@@ -0,0 +1,21 @@
+Checks: >
+  clang-diagnostic-*,
+  clang-analyzer-*,
+  cppcoreguidelines-*,
+  modernize-*,
+  performance-*,
+  readability-*,
+  -modernize-use-trailing-return-type,
+  -readability-identifier-length
+
+# Treat all warnings as errors
+WarningsAsErrors: '*'
+
+# Only warn on headers in the code tree
+HeaderFilterRegex: 'builtins/|runtime/'
+
+# Use the same style as clang-format (look for .clang-format)
+FormatStyle: file
+
+# Don’t analyze temporary dtors (speeds up checking)
+AnalyzeTemporaryDtors: false

CMakeLists.txt

@@ -38,6 +38,7 @@ include("spidermonkey")
 include("openssl")
 include("${HOST_API}/host_api.cmake")
 include("build-crates")
+include("lint")
 
 option(ENABLE_JS_DEBUGGER "Enable support for debugging content via a socket connection" ON)
 

cmake/lint.cmake

@@ -0,0 +1,28 @@
+set(CLANG_TIDY ${WASI_SDK_PREFIX}/bin/clang-tidy)
+set(RUN_CLANG_TIDY ${WASI_SDK_PREFIX}/bin/run-clang-tidy)
+set(CLANG_APPLY_REPLACEMENTS ${WASI_SDK_PREFIX}/bin/clang-apply-replacements)
+set(WASI_SYSROOT ${WASI_SDK_PREFIX}/share/wasi-sysroot)
+
+add_custom_target(clang-tidy
+  COMMAND ${RUN_CLANG_TIDY}
+          -p=${CMAKE_BINARY_DIR}
+          -clang-tidy-binary=${CLANG_TIDY}
+          -extra-arg=--sysroot=${WASI_SYSROOT}
+          -config-file=${CMAKE_SOURCE_DIR}/.clang-tidy
+          ${CMAKE_SOURCE_DIR}/builtins
+  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+  COMMENT "Running clang‑tidy over the codebase"
+  VERBATIM)
+
+add_custom_target(clang-tidy-fix
+  COMMAND ${RUN_CLANG_TIDY}
+          -p=${CMAKE_BINARY_DIR}
+          -clang-tidy-binary=${CLANG_TIDY}
+          -clang-apply-replacements-binary=${CLANG_APPLY_REPLACEMENTS}
+          -extra-arg=--sysroot=${WASI_SYSROOT}
+          -config-file=${CMAKE_SOURCE_DIR}/.clang-tidy
+          -fix
+          ${CMAKE_SOURCE_DIR}/builtins
+  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+  COMMENT "Running clang‑tidy over the codebase and applying fixes"
+  VERBATIM)

justfile

@@ -45,6 +45,12 @@ do_clean:
 clean-all: && do_clean
     @echo "This will remove {{builddir}}"
 
+# Run clang-tidy
+lint: (build "clang-tidy")
+
+# Run clang-tidy and apply offered fixes
+lint-fix: (build "clang-tidy-fix")
+
 # Componentize js script
 componentize script="" outfile="starling.wasm": build
     {{ builddir }}/componentize.sh {{ script }} -o {{ outfile }}