Skip to content

Commit c5f80bd

Browse files
fix(ci): Unify release-please CI workflows (#284)
The previous approach didn't work as I thought it would. I think/hope that this approach will create separate PRs for StarlingMonkey and debugger releases. One thing to note is that this (as the previous version) changes the StarlingMonkey releases to have a `starlingmonkey_` prefix. That seems like the right thing to me, but it does mean that the release artifact paths are changing.
1 parent bd4563e commit c5f80bd

File tree

3 files changed

+41
-75
lines changed

3 files changed

+41
-75
lines changed

.github/workflows/release-please.yml

Lines changed: 40 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,17 @@ jobs:
1414
release-please:
1515
runs-on: ubuntu-latest
1616
outputs:
17+
# StarlingMonkey outputs
1718
release_created: ${{ steps.release.outputs.release_created }}
1819
tag_name: ${{ steps.release.outputs.tag_name }}
20+
# Debugger Extension outputs
21+
debugger_release_created: ${{ steps.release.outputs['debugger/vscode-dap-extension--release_created'] }}
22+
debugger_tag_name: ${{ steps.release.outputs['debugger/vscode-dap-extension--tag_name'] }}
1923
steps:
2024
- uses: googleapis/release-please-action@a02a34c4d625f9be7cb89156071d8567266a2445 #v4.2.0
2125
id: release
2226
with:
2327
token: ${{ secrets.GITHUB_TOKEN }}
24-
release-type: simple
2528

2629
build-and-upload:
2730
needs: release-please
@@ -75,3 +78,39 @@ jobs:
7578
with:
7679
tag_name: ${{ needs.release-please.outputs.tag_name }}
7780
files: release-artifacts/*
81+
82+
publish-extension:
83+
needs: release-please
84+
if: ${{ needs.release-please.outputs.debugger_release_created }}
85+
runs-on: ubuntu-latest
86+
steps:
87+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
88+
89+
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 #v4.4.0
90+
with:
91+
node-version: 'lts/*'
92+
93+
- name: Install dependencies
94+
working-directory: debugger/vscode-dap-extension
95+
run: npm ci
96+
97+
- name: Build extension
98+
working-directory: debugger/vscode-dap-extension
99+
run: npm run build
100+
101+
- name: Package extension
102+
working-directory: debugger/vscode-dap-extension
103+
run: npm run package
104+
105+
- name: Publish to VS Code Marketplace
106+
working-directory: debugger/vscode-dap-extension
107+
run: npm run publish
108+
env:
109+
VSCE_PAT: ${{ secrets.VSCE_PAT }}
110+
111+
- name: Upload VSIX to Release
112+
uses: softprops/action-gh-release@72f2c25fcb47643c292f7107632f7a47c1df5cd8 #2.3.2
113+
with:
114+
tag_name: ${{ needs.release-please.outputs.debugger_tag_name }}
115+
files: debugger/vscode-dap-extension/*.vsix
116+
make_latest: false

.github/workflows/vscode-extension-release.yml

Lines changed: 0 additions & 74 deletions
This file was deleted.

release-please-config.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"bump-minor-pre-major": false,
44
"bump-patch-for-minor-pre-major": false,
55
"include-v-in-tag": true,
6+
"bootstrap-sha": "6cdcc0e8ba3cc8a80e026af3c0867a1f63e57d2a",
67
"packages": {
78
".": {
89
"package-name": "starlingmonkey",

0 commit comments

Comments
 (0)