Skip to content

Commit 1465c3c

Browse files
authored
Unit test:type matching issue and code redundancy (#4079)
1 parent aa05360 commit 1465c3c

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

tests/unit/interpreter/interpreter_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ TEST_F(InterpreterTest, wasm_runtime_is_built_in_module)
4545
bool ret = wasm_runtime_is_built_in_module("env");
4646
ASSERT_TRUE(ret);
4747

48-
ret = ret = wasm_runtime_is_built_in_module("env1");
48+
ret = wasm_runtime_is_built_in_module("env1");
4949
ASSERT_FALSE(ret);
5050
}

tests/unit/wasm-vm/wasm_vm.cc

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class WasmVMTest : public testing::Test
6565

6666
TEST_F(WasmVMTest, Test_app1)
6767
{
68-
unsigned argv[10];
68+
uint32 argv[10];
6969

7070
ASSERT_TRUE(app1_wasm != NULL);
7171

@@ -151,7 +151,7 @@ TEST_F(WasmVMTest, Test_app1)
151151

152152
TEST_F(WasmVMTest, Test_app2)
153153
{
154-
unsigned argv[10];
154+
uint32 argv[10];
155155

156156
/* Load module */
157157
module = wasm_runtime_load(app2_wasm, sizeof(app2_wasm), error_buf,
@@ -416,7 +416,7 @@ TEST_F(WasmVMTest, Test_app2)
416416

417417
TEST_F(WasmVMTest, Test_app3)
418418
{
419-
unsigned argv[10];
419+
uint32 argv[10];
420420

421421
/* Load module */
422422
module = wasm_runtime_load(app3_wasm, sizeof(app3_wasm), error_buf,
@@ -465,7 +465,6 @@ TEST_F(WasmVMTest, Test_app3)
465465
ASSERT_TRUE(buf != NULL);
466466

467467
ASSERT_EQ(wasm_runtime_addr_native_to_app(module_inst, buf), argv[0]);
468-
int32 buf_offset = argv[0];
469468

470469
/* call my_malloc */
471470
func_inst = wasm_runtime_lookup_function(module_inst, "my_malloc");
@@ -482,7 +481,6 @@ TEST_F(WasmVMTest, Test_app3)
482481
ASSERT_TRUE(buf1 != NULL);
483482

484483
ASSERT_EQ(wasm_runtime_addr_native_to_app(module_inst, buf1), argv[0]);
485-
int32 buf_offset1 = argv[0];
486484

487485
wasm_runtime_deinstantiate(module_inst);
488486
wasm_runtime_unload(module);
@@ -526,7 +524,7 @@ TEST_F(WasmVMTest, Test_app4_single)
526524
uint8 *buffer = NULL;
527525
uint32 buffer_size = 0;
528526
bool ret = false;
529-
unsigned argv[10];
527+
uint32 argv[10];
530528

531529
wasm_runtime_set_module_reader(&module_reader_callback,
532530
&module_destroyer_callback);
@@ -584,7 +582,7 @@ TEST_F(WasmVMTest, Test_app4_plus_one)
584582
uint8 *buffer = NULL;
585583
uint32 buffer_size = 0;
586584
bool ret = false;
587-
uint32_t argv[10] = { 0 };
585+
uint32 argv[10] = { 0 };
588586

589587
wasm_runtime_set_module_reader(&module_reader_callback,
590588
&module_destroyer_callback);

0 commit comments

Comments
 (0)