fix: converted ll impl to array, addressed comments

Author: Hritik Gupta

core/iwasm/common/wasm_shared_memory.c

@@ -5,6 +5,7 @@
 
 #include "bh_log.h"
 #include "wasm_shared_memory.h"
+#define WAIT_MAP_SIZE 32
 
 static bh_list shared_memory_list_head;
 static bh_list *const shared_memory_list = &shared_memory_list_head;
@@ -30,10 +31,10 @@ typedef struct AtomicWaitNode {
     korp_cond wait_cond;
 } AtomicWaitNode;
 
-typedef struct AtomicWaitAddressNode {
-    bh_list_link l;
-    void *addr;
-} AtomicWaitAddressNode;
+typedef struct AtomicWaitAddressArgs {
+    uint32 index;
+    void *addr[WAIT_MAP_SIZE];
+} AtomicWaitAddressArgs;
 
 /* Atomic wait map */
 static HashMap *wait_map;
@@ -95,38 +96,31 @@ search_module(WASMModuleCommon *module)
 static void
 create_list_of_waiter_addresses(void *key, void *value, void *user_data)
 {
-    /* add waiter address to atomic wait list */
-    AtomicWaitAddressNode *wait_address_node;
-
-    if (!(wait_address_node =
-              wasm_runtime_malloc(sizeof(AtomicWaitAddressNode)))) {
-        return;
-    }
-    wait_address_node->addr = key;
-    bh_assert(bh_list_insert(user_data, wait_address_node) == BH_LIST_SUCCESS);
+    AtomicWaitAddressArgs *data = (AtomicWaitAddressArgs *)user_data;
+    data->addr[(data->index++) % WAIT_MAP_SIZE] = key;
 }
 
 void
 notify_stale_threads_on_exception(WASMModuleInstanceCommon *module_inst)
 {
-    bh_list atomic_wait_address_list_head;
-    bh_list *const atomic_wait_address_list = &atomic_wait_address_list_head;
-    static korp_mutex atomic_wait_address_list_lock;
-    AtomicWaitAddressNode *node;
-
-    bh_list_status ret = bh_list_init(atomic_wait_address_list);
-    bh_assert(ret == BH_LIST_SUCCESS);
+    AtomicWaitAddressArgs *args = NULL;
+    if (!(args = wasm_runtime_malloc(sizeof(AtomicWaitAddressArgs)))) {
+        return;
+    }
 
-    os_mutex_lock(&atomic_wait_address_list_lock);
-    bh_hash_map_traverse(wait_map, create_list_of_waiter_addresses,
-                         atomic_wait_address_list);
+    memset(args, 0, sizeof(*args));
+    os_mutex_lock(&shared_memory_list_lock);
+    // create list of addresses
+    bh_hash_map_traverse(wait_map, create_list_of_waiter_addresses, args);
+    os_mutex_unlock(&shared_memory_list_lock);
 
-    node = bh_list_first_elem(atomic_wait_address_list);
-    while (node) {
-        wasm_runtime_atomic_notify(module_inst, node->addr, UINT32_MAX);
-        node = bh_list_elem_next(node);
+    // notify
+    for (uint32 i = 0; i < (args->index % WAIT_MAP_SIZE); i++) {
+        wasm_runtime_atomic_notify(module_inst, args->addr[i], UINT32_MAX);
     }
-    os_mutex_unlock(&atomic_wait_address_list_lock);
+
+    // free memory allocated to args data
+    wasm_runtime_free(args);
 }
 
 WASMSharedMemNode *