Fix potential memory leak in insert_native_symbol (#3712)

wenyongh · web-flow · commit 740f499e9c29 · 2024-08-14T18:11:18.000+08:00
diff --git a/core/iwasm/compilation/aot_llvm.c b/core/iwasm/compilation/aot_llvm.c
@@ -3288,6 +3288,7 @@ insert_native_symbol(AOTCompContext *comp_ctx, const char *symbol, int32 idx)
     bh_assert(strlen(symbol) <= sizeof(sym->symbol));
     ret = snprintf(sym->symbol, sizeof(sym->symbol), "%s", symbol);
     if (ret < 0 || ret + 1 > (int)sizeof(sym->symbol)) {
+        wasm_runtime_free(sym);
         aot_set_last_error_v("symbol name too long: %s", symbol);
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -3288,6 +3288,7 @@ insert_native_symbol(AOTCompContext comp_ctx, const char symbol, int32 idx)`
`3288`	`3288`	`bh_assert(strlen(symbol) <= sizeof(sym->symbol));`
`3289`	`3289`	`ret = snprintf(sym->symbol, sizeof(sym->symbol), "%s", symbol);`
`3290`	`3290`	`if (ret < 0 \|\| ret + 1 > (int)sizeof(sym->symbol)) {`
	`3291`	`+ wasm_runtime_free(sym);`
`3291`	`3292`	`aot_set_last_error_v("symbol name too long: %s", symbol);`
`3292`	`3293`	`return false;`
`3293`	`3294`	`}`