fixed terminating stale threads on trap/proc_exit

Author: Hritik Gupta

core/iwasm/common/wasm_runtime_common.c

@@ -2190,6 +2190,10 @@ wasm_set_exception(WASMModuleInstance *module_inst, const char *exception)
     }
 
 #if WASM_ENABLE_THREAD_MGR != 0
+    if (exception) {
+        notify_stale_threads_on_exception(
+            (WASMModuleInstanceCommon *)module_inst);
+    }
     exec_env =
         wasm_clusters_search_exec_env((WASMModuleInstanceCommon *)module_inst);
     if (exec_env) {

core/iwasm/common/wasm_shared_memory.c

@@ -32,6 +32,7 @@ typedef struct AtomicWaitNode {
 
 /* Atomic wait map */
 static HashMap *wait_map;
+static HashMap *wait_map_without_lock;
 
 static uint32
 wait_address_hash(void *address);
@@ -87,6 +88,41 @@ search_module(WASMModuleCommon *module)
     return NULL;
 }
 
+static void
+notify_stale_threads(void *key, void *value, void *user_data)
+{
+    WASMModuleInstanceCommon *module_inst =
+        (WASMModuleInstanceCommon *)user_data;
+    wasm_runtime_atomic_notify(module_inst, key, UINT32_MAX);
+    bh_hash_map_remove(wait_map, key, NULL, NULL);
+}
+
+static void
+create_copy_of_wait_map(void *key, void *value, void *map_copy)
+{
+    bh_hash_map_insert((HashMap *)map_copy, key, value);
+}
+
+void
+notify_stale_threads_on_exception(WASMModuleInstanceCommon *module_inst)
+{
+
+    wait_map_without_lock = bh_hash_map_create(
+        32, false, (HashFunc)wait_address_hash,
+        (KeyEqualFunc)wait_address_equal, NULL, destroy_wait_info);
+    /**
+     * create a copy of wait_map with no lock
+     * this allows invoking methods in the callback
+     * which require acquiring lock on the original map
+     */
+    bh_hash_map_traverse(wait_map, create_copy_of_wait_map,
+                         wait_map_without_lock);
+
+    // terminate stale threads
+    bh_hash_map_traverse(wait_map_without_lock, notify_stale_threads,
+                         module_inst);
+}
+
 WASMSharedMemNode *
 wasm_module_get_shared_memory(WASMModuleCommon *module)
 {

core/iwasm/common/wasm_shared_memory.h

@@ -37,6 +37,9 @@ wasm_shared_memory_init();
 void
 wasm_shared_memory_destroy();
 
+void
+notify_stale_threads_on_exception(WASMModuleInstanceCommon *module);
+
 WASMSharedMemNode *
 wasm_module_get_shared_memory(WASMModuleCommon *module);