Skip to content

Include unstable features in published packages #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lann merged 1 commit into from
Jan 31, 2025
Merged

Include unstable features in published packages #147

lann merged 1 commit into from
Jan 31, 2025

Conversation

@lann
Copy link
Collaborator

@lann lann commented Jan 31, 2025 •
edited
Loading

Sets Resolve::all_features = true to avoid filtering out unstable features.

Added a test and manually verified by round-tripping wasi:[email protected] through wkg publish/get.

Fixes #143

@lann lann marked this pull request as ready for review January 31, 2025 19:08
@lann lann requested a review from thomastaylor312 January 31, 2025 19:09
@lann lann merged commit 1361b55 into bytecodealliance:main Jan 31, 2025
3 checks passed
@lann lann deleted the unstable branch January 31, 2025 19:21
@ricochet ricochet mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect wit for wasi:[email protected] and wasi:[email protected] (unstable features are omitted by default)

2 participants

@lann @thomastaylor312