Skip to content

Commit 1be4159

Browse files
Bas Geertsemajsturtevant
authored andcommitted
Only support non-shared memory for now
Implementing support for shared memory requires seperate data structures and is not simply a boolean flag. Remove this parameter therefore from the Memory constructor to not imply this is properly supported yet.
1 parent ed6e244 commit 1be4159

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/Memory.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ public class Memory : IExternal
1717
/// <param name="minimum">The minimum number of WebAssembly pages.</param>
1818
/// <param name="maximum">The maximum number of WebAssembly pages, or <c>null</c> to not specify a maximum.</param>
1919
/// <param name="is64Bit"><c>true</c> when memory type represents a 64-bit memory, <c>false</c> when it represents a 32-bit memory.</param>
20-
/// <param name="isShared"><c>true</c> when memory is shared, <c>false</c> when it is not shared.</param>
21-
public Memory(Store store, long minimum = 0, long? maximum = null, bool is64Bit = false, bool isShared = false)
20+
public Memory(Store store, long minimum = 0, long? maximum = null, bool is64Bit = false)
2221
{
2322
if (store is null)
2423
{
@@ -44,9 +43,9 @@ public Memory(Store store, long minimum = 0, long? maximum = null, bool is64Bit
4443
Minimum = minimum;
4544
Maximum = maximum;
4645
Is64Bit = is64Bit;
47-
IsShared = isShared;
48-
49-
var typeHandle = Native.wasmtime_memorytype_new((ulong)minimum, maximum is not null, (ulong)(maximum ?? 0), is64Bit, isShared);
46+
IsShared = false;
47+
48+
var typeHandle = Native.wasmtime_memorytype_new((ulong)minimum, maximum is not null, (ulong)(maximum ?? 0), is64Bit, IsShared);
5049
try
5150
{
5251

0 commit comments

Comments
 (0)