ModuleLoadTests had lots of warnings to do with using Read and not checking the return value. Fixed by using ReadExactly instead. (#335)

Author: martindevans

tests/ModuleLoadTests.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Reflection;
 using FluentAssertions;
-using Wasmtime;
 using Xunit;
 
 namespace Wasmtime.Tests
@@ -11,7 +10,7 @@ public class ModuleLoadTests
         [Fact]
         public void ItLoadsModuleFromEmbeddedResource()
         {
-            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wasm");
+            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wasm")!;
             stream.Should().NotBeNull();
 
             using var engine = new Engine();
@@ -20,18 +19,18 @@ public void ItLoadsModuleFromEmbeddedResource()
             // `LoadModule` is not supposed to close the supplied stream,
             // so the following statement should complete without throwing
             // `ObjectDisposedException`
-            stream.Read(new byte[0], 0, 0);
+            stream.ReadExactly(Array.Empty<byte>(), 0, 0);
         }
 
         [Fact]
         public void ItValidatesModuleFromEmbeddedResource()
         {
-            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wasm");
+            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wasm")!;
             stream.Should().NotBeNull();
 
             byte[] buffer = new byte[stream.Length];
 
-            stream.Read(buffer, 0, buffer.Length);
+            stream.ReadExactly(buffer, 0, buffer.Length);
 
             using var engine = new Engine();
             Module.Validate(engine, buffer).Should().BeNull();
@@ -40,7 +39,7 @@ public void ItValidatesModuleFromEmbeddedResource()
         [Fact]
         public void ItLoadsModuleTextFromEmbeddedResource()
         {
-            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wat");
+            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wat")!;
             stream.Should().NotBeNull();
 
             using var engine = new Engine();
@@ -49,13 +48,13 @@ public void ItLoadsModuleTextFromEmbeddedResource()
             // `LoadModuleText` is not supposed to close the supplied stream,
             // so the following statement should complete without throwing
             // `ObjectDisposedException`
-            stream.Read(new byte[0], 0, 0);
+            stream.ReadExactly(new byte[0], 0, 0);
         }
 
         [Fact]
         public void ItCannotBeAccessedOnceDisposed()
         {
-            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wasm");
+            using var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream("hello.wasm")!;
             stream.Should().NotBeNull();
 
             using var engine = new Engine();