Removed a use of GetBytes in Instance.TryGetExtern and using a stack buffer instead. (#287)

martindevans · web-flow · commit e03d3e1c57cb · 2023-12-01T11:01:31.000-08:00
diff --git a/src/Instance.cs b/src/Instance.cs
@@ -581,10 +581,11 @@ public Instance(Store store, Module module, params object[] imports)
 
         private bool TryGetExtern(StoreContext context, string name, out Extern ext)
         {
+            using var nameBytes = name.ToUTF8(stackalloc byte[Math.Min(64, name.Length * 2)]);
+
             unsafe
             {
-                var nameBytes = Encoding.UTF8.GetBytes(name);
-                fixed (byte* ptr = nameBytes)
+                fixed (byte* ptr = nameBytes.Span)
                 {
                     return Native.wasmtime_instance_export_get(context.handle, this.instance, ptr, (UIntPtr)nameBytes.Length, out ext);
                 }

Original file line number	Diff line number	Diff line change
`@@ -581,10 +581,11 @@ public Instance(Store store, Module module, params object[] imports)`
`581`	`581`
`582`	`582`	`private bool TryGetExtern(StoreContext context, string name, out Extern ext)`
`583`	`583`	`{`
	`584`	`+ using var nameBytes = name.ToUTF8(stackalloc byte[Math.Min(64, name.Length * 2)]);`
	`585`	`+`
`584`	`586`	`unsafe`
`585`	`587`	`{`
`586`		`- var nameBytes = Encoding.UTF8.GetBytes(name);`
`587`		`- fixed (byte* ptr = nameBytes)`
	`588`	`+ fixed (byte* ptr = nameBytes.Span)`
`588`	`589`	`{`
`589`	`590`	`return Native.wasmtime_instance_export_get(context.handle, this.instance, ptr, (UIntPtr)nameBytes.Length, out ext);`
`590`	`591`	`}`